Skip to content

Commit 454c31e

Browse files
ci: use '.node-version' file to configure node version used for CI (#3489)
1 parent 21b926a commit 454c31e

File tree

3 files changed

+12
-15
lines changed

3 files changed

+12
-15
lines changed

.github/workflows/canary.yaml

+1-3
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ on:
55
- CI
66
types:
77
- completed
8-
env:
9-
NODE_VERSION_USED_FOR_DEVELOPMENT: 17
108
jobs:
119
publish-canary:
1210
runs-on: ubuntu-latest
@@ -22,7 +20,7 @@ jobs:
2220
uses: actions/setup-node@v2
2321
with:
2422
cache: npm
25-
node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
23+
node-version-file: '.node-version'
2624
# 'registry-url' is required for 'npm publish'
2725
registry-url: 'https://registry.npmjs.org'
2826

.github/workflows/ci.yml

+10-12
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
name: CI
22
on: [push, pull_request]
3-
env:
4-
NODE_VERSION_USED_FOR_DEVELOPMENT: 17
53
jobs:
64
save-github-event:
75
name: "Save `github.event` as an artifact to use in subsequent 'workflow_run' actions"
@@ -26,7 +24,7 @@ jobs:
2624
uses: actions/setup-node@v2
2725
with:
2826
cache: npm
29-
node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
27+
node-version-file: '.node-version'
3028

3129
- name: Install Dependencies
3230
run: npm ci --ignore-scripts
@@ -75,7 +73,7 @@ jobs:
7573
uses: actions/setup-node@v2
7674
with:
7775
cache: npm
78-
node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
76+
node-version-file: '.node-version'
7977

8078
- name: Install Dependencies
8179
run: npm ci --ignore-scripts
@@ -102,7 +100,7 @@ jobs:
102100
- name: Setup Node.js
103101
uses: actions/setup-node@v2
104102
with:
105-
node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
103+
node-version-file: '.node-version'
106104
# We install bunch of packages during integration tests without locking them
107105
# so we skip cache action to not pollute cache for other jobs.
108106

@@ -125,7 +123,7 @@ jobs:
125123
uses: actions/setup-node@v2
126124
with:
127125
cache: npm
128-
node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
126+
node-version-file: '.node-version'
129127

130128
- name: Install Dependencies
131129
run: npm ci --ignore-scripts
@@ -146,7 +144,7 @@ jobs:
146144
uses: actions/setup-node@v2
147145
with:
148146
cache: npm
149-
node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
147+
node-version-file: '.node-version'
150148

151149
- name: Install Dependencies
152150
run: npm ci --ignore-scripts
@@ -204,7 +202,7 @@ jobs:
204202
uses: actions/setup-node@v2
205203
with:
206204
cache: npm
207-
node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
205+
node-version-file: '.node-version'
208206

209207
- name: Install Dependencies
210208
run: npm ci --ignore-scripts
@@ -231,7 +229,7 @@ jobs:
231229
uses: actions/setup-node@v2
232230
with:
233231
cache: npm
234-
node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
232+
node-version-file: '.node-version'
235233

236234
- name: Install Dependencies
237235
run: npm ci --ignore-scripts
@@ -260,7 +258,7 @@ jobs:
260258
uses: actions/setup-node@v2
261259
with:
262260
cache: npm
263-
node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
261+
node-version-file: '.node-version'
264262

265263
- name: Install Dependencies
266264
run: npm ci --ignore-scripts
@@ -288,7 +286,7 @@ jobs:
288286
uses: actions/setup-node@v2
289287
with:
290288
cache: npm
291-
node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
289+
node-version-file: '.node-version'
292290

293291
- name: Install Dependencies
294292
run: npm ci --ignore-scripts
@@ -315,7 +313,7 @@ jobs:
315313
uses: actions/setup-node@v2
316314
with:
317315
cache: npm
318-
node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
316+
node-version-file: '.node-version'
319317

320318
- name: Install Dependencies
321319
run: npm ci --ignore-scripts

.node-version

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
v17

0 commit comments

Comments
 (0)