Skip to content
This repository was archived by the owner on Sep 9, 2022. It is now read-only.

Browser-detection issue #52

Open
RobThree opened this issue Jul 3, 2013 · 0 comments
Open

Browser-detection issue #52

RobThree opened this issue Jul 3, 2013 · 0 comments

Comments

@RobThree
Copy link

RobThree commented Jul 3, 2013

Line 52 of tweets.js contains:

if($.browser.msie && $.browser.version < 8){

This causes a JS error: "Uncaught TypeError: Cannot read property 'msie' of undefined". This is because jQuery deprecated the feature in 1.3 and since 1.9 it has been removed entirely.

If it were up to me I'd drop support for IE < 8 so the entire shim can be removed; if you insist on supporting older browsers you need to find a better way (modernizr might be a good option, 'future proof' but, imho, way overkill) to detect browser version/features.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant