Merge pull request #18998 from uberbrady/fix_scim_error_email

snipe · web-flow · commit 6ee2dc1cd6b6 · 2026-05-11T14:59:56.000+01:00
Don't 500 on malformed emails input
diff --git a/app/Models/SnipeSCIMConfig.php b/app/Models/SnipeSCIMConfig.php
@@ -196,7 +196,12 @@ protected function doRead(&$object, $attributes = [])
                         public function doWrite($operation, $subop, $value, Model &$object, Path $path = null, $removeIfNotSet = false)
                         {
                             if ($value) {
-                                $object->email = $value[0]['value'];
+                                try {
+                                    $object->email = $value[0]['value'];
+                                } catch (\Exception $e) {
+                                    \Log::debug($e);
+                                    throw new SCIMException("Unknown email object:  '" . print_r($value, true) . "'", 422);
+                                }
                             } else {
                                 $object->email = null;
                             }

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,12 @@ protected function doRead(&$object, $attributes = [])`
`196`	`196`	`public function doWrite($operation, $subop, $value, Model &$object, Path $path = null, $removeIfNotSet = false)`
`197`	`197`	`{`
`198`	`198`	`if ($value) {`
`199`		`- $object->email = $value[0]['value'];`
	`199`	`+ try {`
	`200`	`+ $object->email = $value[0]['value'];`
	`201`	`+ } catch (\Exception $e) {`
	`202`	`+ \Log::debug($e);`
	`203`	`+ throw new SCIMException("Unknown email object: '" . print_r($value, true) . "'", 422);`
	`204`	`+ }`
`200`	`205`	`} else {`
`201`	`206`	`$object->email = null;`
`202`	`207`	`}`