Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible unintended code typo (& instead of |) #56

Closed
filipnavara opened this issue Jun 12, 2021 · 5 comments · Fixed by #57
Closed

Possible unintended code typo (& instead of |) #56

filipnavara opened this issue Jun 12, 2021 · 5 comments · Fixed by #57

Comments

@filipnavara
Copy link

gss-ntlmssp/src/gss_sec_ctx.c

Line 401 in 9b6493b

ctx->gss_flags |= GSS_C_CONF_FLAG & GSS_C_INTEG_FLAG;

@simo5
Copy link
Collaborator

simo5 commented Jun 14, 2021

Duh!
That is embarrassing :-D

@simo5
Copy link
Collaborator

simo5 commented Jun 14, 2021

The sad thing is that tests pass either way, so it means that part is not tested ... somehow

@simo5
Copy link
Collaborator

simo5 commented Jun 14, 2021

Ah this break just the reporting, that is why, as the NTLMSSP flags are what are used to do the negotiation ...
Fix incoming.

simo5 added a commit to simo5/gssntlmssp that referenced this issue Jun 14, 2021
@simo5
Fix setting INTEG/CONF on ISC call.
aac6d1d 
When SEAL is negotiated we are supposed to se INTEG and CONF flags, but
instead of using a | to set both a & was used ending up setting nothing.

Fixes gssapi#56

Signed-off-by: Simo Sorce <[email protected]>
@filipnavara
Copy link
Author

Thanks! It didn't actually break any scenario I was testing. I found it when looking at the GSS_C_INTEG_FLAG code and looking for implications of setting the flag when doing client-side negotiation.

@simo5 simo5 mentioned this issue Jun 14, 2021
Merged
@simo5
Copy link
Collaborator

simo5 commented Jun 14, 2021

As soon as tests pass I'll merge, thanks for spotting this, really appreciated.

@simo5 simo5 closed this as completed in #57 Jun 14, 2021
simo5 added a commit that referenced this issue Jun 14, 2021
@simo5
Fix setting INTEG/CONF on ISC call.
f23b571 
When SEAL is negotiated we are supposed to se INTEG and CONF flags, but
instead of using a | to set both a & was used ending up setting nothing.

Fixes #56

Signed-off-by: Simo Sorce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix setting INTEG/CONF on ISC call. simo5/gssntlmssp
2 participants
@filipnavara @simo5