Fix hostbased name #66
Conversation
|
@filipnavara hopefully this addresses the SPN issue. |
|
Nice, |
simo5
force-pushed
the
fix_hostbased_name
branch
from
404e36b to
acbce1b
Compare
|
Glad I added tests, found incorrect behavior with names like "", "@", "@foo.bar", ... |
The SPN is used to fill the Traget Name Attribute in the Target Info array. This means we need to preserver the SPN as passed to us (via conversion from a GSS Name). This patch adds an spn field to the server union part of gssntlm_name structure. Signed-off-by: Simo Sorce <[email protected]>
When we encode/decode/process target_info use the new stored SPN. Also mark the SPN as unverified, because we never know if the calling code speaks authoritatively, and may be passing an incorrect name. Signed-off-by: Simo Sorce <[email protected]>
This ups both context and credentials export versions as the size and content of the serilized structires change. Signed-off-by: Simo Sorce <[email protected]>
simo5
force-pushed
the
fix_hostbased_name
branch
from
acbce1b to
2035e33
Compare
Not at the moment but I will try it and cross check with other implementations! |
|
Alright, in the meanwhile I'll push this code as is, can always correct later if anything comes up about current behavior vs other implementations. |
|
Please note that the implementation will not currently set Traget Name in Target Info if a gss name is obtained that only includes a name and not a full spn ... |
Fixes #63