SuppressMessage placed near source of issues.

Author: gsscoder

CommandLine.sln.DotSettings.user

@@ -1,3 +1,7 @@
+2013-01-22	Giacomo Stelluti Scala	<[email protected]>
+
+  * FxCop SuppressMessage attributes placed in right place (near source of issue).
+
 2013-01-22	Giacomo Stelluti Scala	<[email protected]>
 
   * Refactored BaseOptionAttribute to avoid virtual member call in ctor in OptionAttribute (FxCop CA2214).

doc/ChangeLog

@@ -39,7 +39,6 @@ namespace CommandLine
     /// Must be applied to a field compatible with an <see cref="System.Collections.Generic.IList&lt;T&gt;"/> interface
     /// of <see cref="System.String"/> instances.
     /// </summary>
-    [SuppressMessage("Microsoft.Design", "CA1019:DefineAccessorsForAttributeArguments", Justification = "The char Separator property matches shortName char constructor argument because the ShortName property is defined in BaseOptionAttribute as nullable char.")]
     [AttributeUsage(AttributeTargets.Property, AllowMultiple = false, Inherited = true)]
     public sealed class OptionListAttribute : BaseOptionAttribute
     {
@@ -87,6 +86,8 @@ public OptionListAttribute(char shortName, string longName, char separator)
         /// <summary>
         /// Gets or sets the values separator character.
         /// </summary>
-        public char Separator { get; set; }
+        public char Separator { get;
+            [SuppressMessage("Microsoft.Design", "CA1019:DefineAccessorsForAttributeArguments", Justification = "The char Separator property matches shortName char constructor argument because the ShortName property is defined in BaseOptionAttribute as nullable char.")]
+            set; }
     }
 }

src/libcmdline/Attributes/OptionListAttribute.cs

@@ -40,8 +40,6 @@ namespace CommandLine
     /// Provides methods to parse command line arguments.
     /// Default implementation for <see cref="CommandLine.ICommandLineParser"/>.
     /// </summary>
-
-    [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "singleton", Justification = "The constructor that accepts a boolean is designed to support default singleton, the parameter is ignored.")]
     public partial class CommandLineParser : ICommandLineParser, IDisposable
     {
         /// <summary>
@@ -52,7 +50,7 @@ public CommandLineParser()
             _settings = new CommandLineParserSettings();
         }
 
-        // special constructor for singleton instance, parameter ignored
+        [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "singleton", Justification = "The constructor that accepts a boolean is designed to support default singleton, the parameter is ignored.")]
         private CommandLineParser(bool singleton)
         {
             _settings = new CommandLineParserSettings(false, false, Console.Error);

src/libcmdline/CommandLineParser.cs

@@ -37,9 +37,7 @@
 #endregion
 
 namespace CommandLine.Internal
-{
-
-    [SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes", Justification = "FormatException (thrown by ConvertFromString) is thrown as Exception.InnerException, so we've to catch directly System.Exception.")]
+{ 
     [DebuggerDisplay("ShortName = {ShortName}, LongName = {LongName}")]
     sealed class OptionInfo
     {
@@ -125,6 +123,7 @@ private bool SetValueScalar(string value, object options)
             return true;
         }
 
+        [SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes", Justification = "FormatException (thrown by ConvertFromString) is thrown as Exception.InnerException, so we've to catch directly System.Exception.")]
         private bool SetNullableValue(string value, object options)
         {
             var nc = new NullableConverter(_property.PropertyType);