All name of test fixture methods changed to a new convention.

Author: gsscoder

CommandLine.sln.DotSettings.user

@@ -11,6 +11,7 @@ Compatibility:
 
 News: 
 ---
+  -  All names of test fixture methods changed to a new convention (using https://gist.github.com/4655503).
   - Started refactoring on test project (migrating from NUnit to Xunit).
   - Thanks to @marcells, we can reference CommandLine.dll from CommandLine.Tests.dll keeping strong name.
   - Introduced ``ValueOptionAttribute`` enhancement of issue #33.

README.md

@@ -1,3 +1,8 @@
+2013-01-28	Giacomo Stelluti Scala	<gsscoder@gmail.com>
+
+  * All name of test fixture methods changed to a new convention (e.g.: A_descriptive_assertion)
+      using https://gist.github.com/4655503.
+
 2013-01-27	Giacomo Stelluti Scala	<gsscoder@gmail.com>
 
   * Started refactoring on test project (migrating from NUnit to Xunit).

doc/ChangeLog

@@ -33,7 +33,6 @@
 
 namespace CommandLine.Tests
 {
-    
     public class AttributesFixture
     {
         class CustomOptionAttribute : BaseOptionAttribute
@@ -79,36 +78,36 @@ public CustomOptionAttribute(char shortName, string longName)
 
         #region API change 01
         [Fact]
-        public void ShortNameWithLineTerminatorThrowsException()
+        public void Short_name_with_line_terminator_throws_exception()
         {
             Assert.Throws<ArgumentException>(() =>
                 new OptionAttribute('\n'));
         }
 
         [Fact]
-        public void ShortNameWithLineTerminatorThrowsException_2()
+        public void Short_name_with_line_terminator_throws_exception_2()
         {
             Assert.Throws<ArgumentException>(() =>
                 new OptionAttribute('\r'));
         }
 
         [Fact]
-        public void ShortNameWithWhiteSpaceThrowsException()
+        public void Short_name_with_white_space_throws_exception()
         {
             Assert.Throws<ArgumentException>(() =>
                 new OptionAttribute(' '));
         }
 
         [Fact]
-        public void ShortNameWithWhiteSpaceThrowsException_2()
+        public void Short_name_with_white_space_throws_exception_2()
         {
             Assert.Throws<ArgumentException>(() =>
                 new OptionAttribute('\t'));
         }
         #endregion
 
         [Fact]
-        public void AllOptionsAllowOneCharacterInShortName()
+        public void All_options_allow_one_character_in_short_name()
         {
             new OptionAttribute('o', null);
             new OptionListAttribute('l', null);
@@ -117,12 +116,12 @@ public void AllOptionsAllowOneCharacterInShortName()
         }
 
         [Fact]
-        public void AllOptionsAllowNullValueInShortName()
+        public void All_options_allow_null_value_in_short_name()
         {
             new OptionAttribute("option-attr");
             new OptionListAttribute("option-list-attr");
             new HelpOptionAttribute("help-attr");
             new CustomOptionAttribute("custom-attr");
         }
     }
-}
+}

src/tests/Attributes/AttributesFixture.cs

@@ -28,16 +28,14 @@
 #endregion
 #region Using Directives
 using System;
-using System.ComponentModel;
 using System.IO;
 using CommandLine.Text;
 using Xunit;
 using FluentAssertions;
 #endregion
 
 namespace CommandLine.Tests
-{
-    
+{  
     public class HelpOptionAttributeFixture : CommandLineParserBaseFixture
     {
         #region Mock Objects
@@ -72,7 +70,7 @@ public string GetUsage()
         #endregion
 
         [Fact]
-        public void CorrectInputNotActivatesHelp()
+        public void Correct_input_not_activates_help()
         {
             var options = new MockOptions();
             var writer = new StringWriter();
@@ -85,7 +83,7 @@ public void CorrectInputNotActivatesHelp()
         }
 
         [Fact]
-        public void BadInputActivatesHelp()
+        public void Bad_input_activates_help()
         {
             var options = new MockOptions();
             var writer = new StringWriter();
@@ -102,7 +100,7 @@ public void BadInputActivatesHelp()
         }
 
         [Fact]
-        public void ExplicitHelpActivation()
+        public void Explicit_help_activation()
         {
             var options = new MockOptions();
             var writer = new StringWriter();
@@ -116,4 +114,4 @@ public void ExplicitHelpActivation()
             (helpText.Length > 0).Should().BeTrue();
         }
     }
-}
+}

src/tests/Attributes/HelpOptionAttributeFixture.cs

@@ -51,33 +51,33 @@ private class MockOptions
         #endregion
 
         [Fact]
-        public void WillThrowExceptionIfConcreteTypeIsNull()
+        public void Will_throw_exception_if_concrete_type_is_null()
         {
             Assert.Throws<ArgumentNullException>(
                 () => new ValueListAttribute(null));
         }
 
         [Fact]
-        public void WillThrowExceptionIfConcreteTypeIsIncompatible()
+        public void Will_throw_exception_if_concrete_type_is_incompatible()
         {
              Assert.Throws<CommandLineParserException>(
                 () => new ValueListAttribute(new List<object>().GetType()));
         }
 
         [Fact]
-        public void ConcreteTypeIsGenericListOfString()
+        public void Concrete_type_is_generic_list_of_string()
         {
             new ValueListAttribute(new List<string>().GetType());
         }
 
         [Fact]
-        public void ConcreteTypeIsGenericListOfStringSubType()
+        public void Concrete_type_is_generic_list_of_string_sub_type()
         {
             new ValueListAttribute(new MockSpecializedList().GetType());
         }
 
         [Fact]
-        public void GetGenericListOfStringInterfaceReference()
+        public void Get_generic_list_of_string_interface_reference()
         {
             var options = new MockOptions();
 
@@ -87,7 +87,7 @@ public void GetGenericListOfStringInterfaceReference()
         }
 
         [Fact]
-        public void UseGenericListOfStringInterfaceReference()
+        public void Use_generic_list_of_string_interface_reference()
         {
             var options = new MockOptions();
 
@@ -99,4 +99,4 @@ public void UseGenericListOfStringInterfaceReference()
             base.ElementsShouldBeEqual(new string[] { "value0", "value1", "value2" }, options.Values);
         }
     }
-}
+}

src/tests/Attributes/ValueListAttributeFixture.cs

@@ -47,13 +47,27 @@
     </Reference>
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="Attributes\AttributesFixture.cs" />
+    <Compile Include="Attributes\HelpOptionAttributeFixture.cs" />
+    <Compile Include="Attributes\ValueListAttributeFixture.cs" />
+    <Compile Include="Core\ArgumentParserFixture.cs" />
+    <Compile Include="Core\EnumeratorsFixture.cs" />
+    <Compile Include="Core\OptionMapFixture.cs" />
     <Compile Include="Mocks\CommandLineOptionsBase.cs" />
     <Compile Include="Mocks\SimpleOptionsWithValueOptionAndValueList.cs" />
     <Compile Include="Mocks\SimpleOptionsWithValueOption.cs" />
     <Compile Include="Mocks\SimpleOptionsForStrict.cs" />
     <Compile Include="Mocks\OptionsWithVerbsHelp.cs" />
     <Compile Include="Mocks\OptionsWithVerbs.cs" />
+    <Compile Include="Parser\CommandLineParserFixture.cs" />
+    <Compile Include="Parser\CommandLineParserSettingsFixture.cs" />
+    <Compile Include="Parser\MutuallyExclusiveParsingFixture.cs" />
+    <Compile Include="Parser\NullableTypesParsingFixture.cs" />
+    <Compile Include="Parser\OptionArrayAttributeParsingFixture.cs" />
+    <Compile Include="Parser\SingletonFixture.cs" />
     <Compile Include="Parser\StrictFixture.cs" />
+    <Compile Include="Parser\UnknownArgumentsFixture.cs" />
+    <Compile Include="Parser\ValueListAttributeParsingFixture.cs" />
     <Compile Include="Parser\ValueOptionAttributeParsingFixture.cs" />
     <Compile Include="Parser\VerbsFixture.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
@@ -79,35 +93,21 @@
     <Compile Include="Mocks\SimpleOptionsWithHelpOption.cs" />
     <Compile Include="Mocks\SimpleOptionsWithOptionList.cs" />
     <Compile Include="Mocks\SimpleOptionsWithValueList.cs" />
-    <Compile Include="Attributes\AttributesFixture.cs" />
-    <Compile Include="Attributes\HelpOptionAttributeFixture.cs" />
-    <Compile Include="Attributes\ValueListAttributeFixture.cs" />
-    <Compile Include="Core\ArgumentParserFixture.cs" />
-    <Compile Include="Core\EnumeratorsFixture.cs" />
-    <Compile Include="Core\OptionMapFixture.cs" />
-    <Compile Include="Parser\CommandLineParserFixture.cs" />
-    <Compile Include="Parser\CommandLineParserSettingsFixture.cs" />
-    <Compile Include="Parser\MutuallyExclusiveParsingFixture.cs" />
-    <Compile Include="Parser\NullableTypesParsingFixture.cs" />
-    <Compile Include="Parser\OptionArrayAttributeParsingFixture.cs" />
-    <Compile Include="Parser\ValueListAttributeParsingFixture.cs" />
-    <Compile Include="Text\CopyrightInfoFixture.cs" />
-    <Compile Include="Text\HeadingInfoFixture.cs" />
-    <Compile Include="Text\HelpTextFixture.cs" />
-    <Compile Include="Text\VerbsHelpTextFixture.cs" />
-    <Compile Include="Parser\SingletonFixture.cs" />
     <Compile Include="Mocks\SimpleOptionsWithDefaults.cs" />
     <Compile Include="Mocks\SimpleOptionsWithBadDefaults.cs" />
     <Compile Include="Mocks\SimpleOptionsWithDefaultArray.cs" />
     <Compile Include="Mocks\RPEOptions.cs" />
     <Compile Include="Mocks\SimpleOptionsForAutoBuid.cs" />
-    <Compile Include="Parser\UnknownArgumentsFixture.cs" />
     <Compile Include="Mocks\OptionsForPlugInScenario.cs" />
     <Compile Include="Mocks\OptionsWithUIntArray.cs" />
-    <Compile Include="Text\MultiLineTextAttributeFixture.cs" />
     <Compile Include="..\CommonAssemblyInfo.cs">
       <Link>Properties\CommonAssemblyInfo.cs</Link>
     </Compile>
+    <Compile Include="Text\CopyrightInfoFixture.cs" />
+    <Compile Include="Text\HeadingInfoFixture.cs" />
+    <Compile Include="Text\HelpTextFixture.cs" />
+    <Compile Include="Text\MultiLineTextAttributeFixture.cs" />
+    <Compile Include="Text\VerbsHelpTextFixture.cs" />
     <Compile Include="Utils\ReflectionUtilFixture.cs" />
   </ItemGroup>
   <ItemGroup>
@@ -120,5 +120,6 @@
       <Name>CommandLine</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup />
   <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
 </Project>

src/tests/CommandLine.Tests.csproj

@@ -39,7 +39,7 @@ namespace CommandLine.Tests
     public class ArgumentParserFixture : BaseFixture
     {
         [Fact]
-        public void GetNextInputValues()
+        public void Get_next_input_values()
         {
             var ae = new StringArrayEnumerator(new string[] { "--optarr", "one", "two", "--plain", "3" });
 
@@ -51,4 +51,4 @@ public void GetNextInputValues()
             ae.Current.Should().Be("two");
         }
     }
-}
+}

src/tests/Core/ArgumentParserFixture.cs

@@ -34,11 +34,10 @@
 
 namespace CommandLine.Tests
 {
-    
     public class EnumeratorsFixture
     {
         [Fact]
-        public void StringIteration()
+        public void String_iteration()
         {
             const string valueOne = "one";
             const string valueTwo = "two";
@@ -66,7 +65,7 @@ public void StringIteration()
         }
 
         [Fact]
-        public void CharIteration()
+        public void Char_iteration()
         {
             IArgumentEnumerator e = new OneCharStringEnumerator("abcd");
             e.MoveNext();
@@ -96,4 +95,4 @@ public void CharIteration()
             e.IsLast.Should().BeTrue();
         }
     }
-}
+}

src/tests/Core/EnumeratorsFixture.cs

@@ -89,7 +89,7 @@ public OptionMap OptionMap
         #endregion
 
         [Fact]
-        public void ManageOptions()
+        public void Manage_options()
         {
             var omBuilder = new OptionMapBuilder(3);
             omBuilder.AppendOption('p', "pretend");
@@ -146,4 +146,5 @@ private static OptionMap CreateMap (ref OptionMap map, IDictionary<string, Optio
             return map;
         }
     }
-}
+}
+