Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11 support #56

Merged
merged 20 commits into from
Nov 13, 2024
Merged

Laravel 11 support #56

merged 20 commits into from
Nov 13, 2024

Conversation

Plytas
Copy link
Collaborator

@Plytas Plytas commented Nov 8, 2024

Added Laravel 11 support as requested in #55. This also results in increased minimum php version to 8.2 as per Laravel documentation. We should be able to support php 8.1, but only for Laravel 10.
image

Most changes are from running pint.

Decided to drop Laravel 9 support as it's past it's end of life. Also updated CI to run test on php8.3 too.

@Plytas Plytas requested a review from gtmassey November 8, 2024 08:44
@Plytas Plytas self-assigned this Nov 8, 2024
@Plytas Plytas added the enhancement New feature or request label Nov 8, 2024
@Plytas
Copy link
Collaborator Author

Plytas commented Nov 8, 2024

@gtmassey this requires a new version of https://github.com/gtmassey/period. I see there's a an open PR for it gtmassey/period#2.

@gtmassey
Copy link
Owner

gtmassey commented Nov 9, 2024

@Plytas I didn't see the original PR on Period, and now I'm messing around with the support. It looks like I will have to drop Laravel 9 support for Period as well, because I can't seem the package to support both L9 and L11 simultaneously, which is a bummer, because I'd like to keep the PHP base support to 8.1+

So, I'll work on adding laravel 11 support and dropping laravel 9 support on Period, which will also impact a few other things. Might take a bit for it to come through, then I'll re-run the tests here and approve the PR.

@gtmassey
Copy link
Owner

I'm not sure if this is possible with the different version constraints, but since Laravel 10 supports php8.1, I'm working to see if we can get this package and gtmassey/period to support php8.1 and up, while still supporting Laravel 10 and 11. But I think that it will cause conflicts with Laravel 11.

@gtmassey
Copy link
Owner

I updated a few things on composer, and ran pint, but the tests are failing for some reason. I haven't quite figured out why, but the error I keep getting is "Could not construct ApplicationDefaultCredentials" on several tests across the package.

@gtmassey gtmassey mentioned this pull request Nov 12, 2024
@gtmassey gtmassey merged commit 58b9fa2 into main Nov 13, 2024
12 checks passed
@gtmassey gtmassey deleted the laravel-11-support branch November 13, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants