Skip to content

build: ignore res for serena#979

Merged
ctron merged 1 commit intoguacsec:mainfrom
ctron:feature/ignore_res_1
Apr 10, 2026
Merged

build: ignore res for serena#979
ctron merged 1 commit intoguacsec:mainfrom
ctron:feature/ignore_res_1

Conversation

@ctron
Copy link
Copy Markdown
Contributor

@ctron ctron commented Apr 9, 2026

Serena MCP fails to start up due to following symlinks and considering the res folder an infinite loop.

However, it seems the only possible way to have it ignore this folder is to add it to gitignore. So we add the folder itself, but ignore it's content. git does that anyway, but now also serena does it.

Summary by Sourcery

Build:

  • Add a crate-level .gitignore entry to ignore contents of the res folder while keeping the directory itself tracked.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Apr 9, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduces a crate-specific .gitignore to exclude the contents of the res directory from version control and Serena MCP’s filesystem traversal, while keeping the res directory itself present in the repository.

File-Level Changes

Change Details Files
Add crate-level ignore rules so Serena MCP and Git both skip the contents of the res directory but keep the directory itself.
  • Create a new .gitignore file scoped to the crate directory.
  • Configure ignore patterns so that the res directory is tracked but its nested files and folders are ignored.
  • Align Git ignore behavior with Serena MCP’s directory traversal to prevent startup failures caused by symlink loops in res.
crate/.gitignore

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Serena MCP fails to start up due to following symlinks and
considering the `res` folder an infinite loop.

However, it seems the only possible way to have it ignore this
folder is to add it to gitignore. So we add the folder itself,
but ignore it's content. `git` does that anyway, but now also
serena does it.
@ctron ctron force-pushed the feature/ignore_res_1 branch from cf38061 to deb7e00 Compare April 9, 2026 09:15
@ctron ctron enabled auto-merge April 9, 2026 09:15
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.81%. Comparing base (2c1b241) to head (deb7e00).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
- Coverage   66.83%   66.81%   -0.03%     
==========================================
  Files         221      221              
  Lines        3881     3881              
  Branches      898      898              
==========================================
- Hits         2594     2593       -1     
- Misses        945      946       +1     
  Partials      342      342              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ctron ctron added this pull request to the merge queue Apr 10, 2026
Merged via the queue into guacsec:main with commit 432f5a6 Apr 10, 2026
11 checks passed
@github-project-automation github-project-automation bot moved this to Done in Trustify Apr 10, 2026
@ctron ctron deleted the feature/ignore_res_1 branch April 10, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants