From 2d019fd48f26428f52dc814dea59049783310000 Mon Sep 17 00:00:00 2001 From: Jake Date: Mon, 9 Sep 2024 12:37:35 +0100 Subject: [PATCH] Bump commercial to 21.0.1 (#27465) --- common/app/conf/switches/ABTestSwitches.scala | 13 +-------- package.json | 2 +- .../common/modules/experiments/ab-tests.ts | 4 --- .../experiments/tests/mpu-when-no-epic.ts | 29 ------------------- .../tests/optimise-spacefinder-inline.ts | 28 ------------------ yarn.lock | 10 +++---- 6 files changed, 7 insertions(+), 79 deletions(-) delete mode 100644 static/src/javascripts/projects/common/modules/experiments/tests/mpu-when-no-epic.ts delete mode 100644 static/src/javascripts/projects/common/modules/experiments/tests/optimise-spacefinder-inline.ts diff --git a/common/app/conf/switches/ABTestSwitches.scala b/common/app/conf/switches/ABTestSwitches.scala index 8dbf761e87ab..01afb8c9a313 100644 --- a/common/app/conf/switches/ABTestSwitches.scala +++ b/common/app/conf/switches/ABTestSwitches.scala @@ -41,18 +41,7 @@ trait ABTestSwitches { "Test the Opt Out frequency capping feature", owners = Seq(Owner.withEmail("commercial.dev@theguardian.com")), safeState = Off, - sellByDate = Some(LocalDate.of(2024, 9, 13)), - exposeClientSide = true, - ) - - Switch( - ABTests, - "ab-optimise-spacefinder-inline", - "Test new Spacefinder margins for inline1", - owners = Seq(Owner.withEmail("commercial.dev@theguardian.com")), - safeState = Off, - sellByDate = Some(LocalDate.of(2024, 9, 13)), + sellByDate = Some(LocalDate.of(2024, 9, 30)), exposeClientSide = true, ) - } diff --git a/package.json b/package.json index 35efd899041e..057b08480c50 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,7 @@ "@emotion/react": "11.11.1", "@emotion/styled": "^10.0.27", "@guardian/ab-core": "8.0.0", - "@guardian/commercial": "20.8.0", + "@guardian/commercial": "21.0.1", "@guardian/core-web-vitals": "6.0.0", "@guardian/eslint-config-typescript": "9.0.1", "@guardian/identity-auth": "3.0.0", diff --git a/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts b/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts index 6e94243a6edb..af2353c38ee2 100644 --- a/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts +++ b/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts @@ -1,6 +1,4 @@ import type { ABTest } from '@guardian/ab-core'; -import { mpuWhenNoEpic } from './tests/mpu-when-no-epic'; -import { optimiseSpacefinderInline } from './tests/optimise-spacefinder-inline'; import { remoteRRHeaderLinksTest } from './tests/remote-header-test'; import { signInGateMainControl } from './tests/sign-in-gate-main-control'; import { signInGateMainVariant } from './tests/sign-in-gate-main-variant'; @@ -11,6 +9,4 @@ export const concurrentTests: readonly ABTest[] = [ signInGateMainVariant, signInGateMainControl, remoteRRHeaderLinksTest, - mpuWhenNoEpic, - optimiseSpacefinderInline, ]; diff --git a/static/src/javascripts/projects/common/modules/experiments/tests/mpu-when-no-epic.ts b/static/src/javascripts/projects/common/modules/experiments/tests/mpu-when-no-epic.ts deleted file mode 100644 index ac9b38764533..000000000000 --- a/static/src/javascripts/projects/common/modules/experiments/tests/mpu-when-no-epic.ts +++ /dev/null @@ -1,29 +0,0 @@ -import type { ABTest } from '@guardian/ab-core'; - -export const mpuWhenNoEpic: ABTest = { - id: 'MpuWhenNoEpic', - author: '@commercial-dev', - start: '2023-11-22', - expiry: '2024-04-30', - audience: 10 / 100, - audienceOffset: 5 / 100, - audienceCriteria: '', - successMeasure: '', - description: - 'Test MPU when there is no epic at the end of Article on the page.', - variants: [ - { - id: 'control', - test: (): void => { - /* no-op */ - }, - }, - { - id: 'variant', - test: (): void => { - /* no-op */ - }, - }, - ], - canRun: () => true, -}; diff --git a/static/src/javascripts/projects/common/modules/experiments/tests/optimise-spacefinder-inline.ts b/static/src/javascripts/projects/common/modules/experiments/tests/optimise-spacefinder-inline.ts deleted file mode 100644 index 7d463cbb5b8a..000000000000 --- a/static/src/javascripts/projects/common/modules/experiments/tests/optimise-spacefinder-inline.ts +++ /dev/null @@ -1,28 +0,0 @@ -import type { ABTest } from '@guardian/ab-core'; - -export const optimiseSpacefinderInline: ABTest = { - id: 'OptimiseSpacefinderInline', - author: '@commercial-dev', - start: '2024-08-08', - expiry: '2024-09-13', - audience: 5 / 100, - audienceOffset: 0 / 100, - audienceCriteria: '', - successMeasure: '', - description: 'Test new spacefinder rules for inline1 ads on desktop.', - variants: [ - { - id: 'control', - test: (): void => { - /* no-op */ - }, - }, - { - id: 'variant', - test: (): void => { - /* no-op */ - }, - }, - ], - canRun: () => true, -}; diff --git a/yarn.lock b/yarn.lock index 726875147e15..abfb55482f20 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4039,9 +4039,9 @@ __metadata: languageName: node linkType: hard -"@guardian/commercial@npm:20.8.0": - version: 20.8.0 - resolution: "@guardian/commercial@npm:20.8.0" +"@guardian/commercial@npm:21.0.1": + version: 21.0.1 + resolution: "@guardian/commercial@npm:21.0.1" dependencies: "@changesets/cli": "npm:^2.26.2" "@guardian/prebid.js": "npm:8.52.0-2" @@ -4060,7 +4060,7 @@ __metadata: "@guardian/libs": ^18.0.0 "@guardian/source": ^6.0.0 typescript: ~5.5.3 - checksum: 10c0/b10a1f1531c162088e5321cee7de4c5916cd37b1013ffaad5a882221e86901312d15f0dcea632be774aa2cf34418077f10a33c9299854f50d16940944ec0cb98 + checksum: 10c0/f1b8f9ae90e51fa741ccd108fa423713a6f0c0303c44e24bdaf55d530235c41973b662d387004d10145e8549068617520b619f40df441c4f6c61f6bf10604e83 languageName: node linkType: hard @@ -4133,7 +4133,7 @@ __metadata: "@emotion/react": "npm:11.11.1" "@emotion/styled": "npm:^10.0.27" "@guardian/ab-core": "npm:8.0.0" - "@guardian/commercial": "npm:20.8.0" + "@guardian/commercial": "npm:21.0.1" "@guardian/core-web-vitals": "npm:6.0.0" "@guardian/eslint-config-typescript": "npm:9.0.1" "@guardian/identity-auth": "npm:3.0.0"