From 81d5d1611f7a3aaa7adf7f6c4b1e30d37136432a Mon Sep 17 00:00:00 2001
From: Natasha <67543397+NovemberTang@users.noreply.github.com>
Date: Mon, 22 Apr 2024 12:52:41 +0100
Subject: [PATCH] Revert "make the others readonly too"

This reverts commit 0353460ff44a59e601e62143d1bf8712ec98b0a7.
---
 .../service-catalogue.test.ts.snap            | 25 -------------------
 packages/cdk/lib/cloudquery/task.ts           |  2 --
 2 files changed, 27 deletions(-)

diff --git a/packages/cdk/lib/__snapshots__/service-catalogue.test.ts.snap b/packages/cdk/lib/__snapshots__/service-catalogue.test.ts.snap
index 6a6019305..b25769459 100644
--- a/packages/cdk/lib/__snapshots__/service-catalogue.test.ts.snap
+++ b/packages/cdk/lib/__snapshots__/service-catalogue.test.ts.snap
@@ -417,7 +417,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-AwsCostExplorerFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -1111,7 +1110,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-DelegatedToSecurityAccountFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "1024",
@@ -1758,7 +1756,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-DeployToolsListOrgsFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -2413,7 +2410,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-FastlyServicesFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -3063,7 +3059,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-GalaxiesFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -3991,7 +3986,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-GitHubIssuesFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -4427,7 +4421,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-GitHubLanguagesFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -5098,7 +5091,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-GitHubRepositoriesFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -5799,7 +5791,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-GitHubTeamsFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "2048",
@@ -6367,7 +6358,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-NS1PluginContainer",
-            "ReadonlyRootFilesystem": true,
           },
           {
             "Command": [
@@ -6482,7 +6472,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-NS1Firelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -7140,7 +7129,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-OrgWideAutoScalingGroupsFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -7790,7 +7778,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-OrgWideBackupFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -8438,7 +8425,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-OrgWideCertificatesFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -9116,7 +9102,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-OrgWideCloudFormationFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -9968,7 +9953,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-OrgWideCloudwatchAlarmsFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -10382,7 +10366,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-OrgWideDynamoDBFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -11070,7 +11053,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-OrgWideEc2Firelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -11722,7 +11704,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-OrgWideInspectorFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -12605,7 +12586,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-OrgWideLoadBalancersFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -13256,7 +13236,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-OrgWideRDSFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -13670,7 +13649,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-OrgWideS3Firelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -14381,7 +14359,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-RemainingAwsDataFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "1024",
@@ -15309,7 +15286,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-RiffRaffDataFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
@@ -15728,7 +15704,6 @@ spec:
               },
             },
             "Name": "CloudquerySource-SnykAllFirelens",
-            "ReadonlyRootFilesystem": true,
           },
         ],
         "Cpu": "256",
diff --git a/packages/cdk/lib/cloudquery/task.ts b/packages/cdk/lib/cloudquery/task.ts
index 2cad17a12..94a8309b7 100644
--- a/packages/cdk/lib/cloudquery/task.ts
+++ b/packages/cdk/lib/cloudquery/task.ts
@@ -290,7 +290,6 @@ export class ScheduledCloudqueryTask extends ScheduledFargateTask {
 					image: dockerDistributedPluginImage,
 					logging: fireLensLogDriver,
 					essential: false,
-					readonlyRootFilesystem: true,
 				},
 			);
 
@@ -400,7 +399,6 @@ export class ScheduledCloudqueryTask extends ScheduledFargateTask {
 			firelensConfig: {
 				type: FirelensLogRouterType.FLUENTBIT,
 			},
-			readonlyRootFilesystem: true,
 		});
 
 		managedPolicies.forEach((policy) => task.taskRole.addManagedPolicy(policy));