Skip to content

Commit

Permalink
Merge pull request #65 from guardian/pm-remove-test-emails
Browse files Browse the repository at this point in the history
Remove notifications to digital.investigations
  • Loading branch information
philmcmahon authored Mar 12, 2024
2 parents 3bdca29 + 17171dd commit 2dad33d
Showing 1 changed file with 1 addition and 23 deletions.
24 changes: 1 addition & 23 deletions packages/cdk/lib/transcription-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,7 @@ import { Runtime } from 'aws-cdk-lib/aws-lambda';
import { SqsEventSource } from 'aws-cdk-lib/aws-lambda-event-sources';
import { HttpMethods } from 'aws-cdk-lib/aws-s3';
import { Topic } from 'aws-cdk-lib/aws-sns';
import {
EmailSubscription,
SqsSubscription,
} from 'aws-cdk-lib/aws-sns-subscriptions';
import { SqsSubscription } from 'aws-cdk-lib/aws-sns-subscriptions';
import { Queue } from 'aws-cdk-lib/aws-sqs';

export class TranscriptionService extends GuStack {
Expand Down Expand Up @@ -254,25 +251,6 @@ export class TranscriptionService extends GuStack {
},
);

// for testing purposes - probably eventually replaced with destination lambda. To avoid endless emails only apply
// on PROD - we can manually set up subscriptions to specific developer emails in the console if needs be on CODE
if (props.stage === 'PROD') {
const destinationSNSTestEmail = new GuStringParameter(
this,
'DestinationSNSTestEmail',
{
fromSSM: true,
default: `/${this.stage}/${this.stack}/${APP_NAME}/destinationSNSTestEmail`,
description:
'Email address to send SNS notifications to for testing purposes',
},
);
const emailSubscription = new EmailSubscription(
destinationSNSTestEmail.valueAsString,
);
transcriptDestinationTopic.addSubscription(emailSubscription);
}

// worker autoscaling group

const workerApp = `${APP_NAME}-worker`;
Expand Down

0 comments on commit 2dad33d

Please sign in to comment.