Merge pull request #129 from guardian/pm-add-tmp-volume-media-download

Add /tmp volume to media download task container
guardian · Feb 7, 2025 · db82a5a · db82a5a
2 parents e37b2c2 + b9e0c9c
commit db82a5a
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 6 deletions.
diff --git a/packages/cdk/lib/__snapshots__/transcription-service.test.ts.snap b/packages/cdk/lib/__snapshots__/transcription-service.test.ts.snap
@@ -2104,7 +2104,12 @@ service transcription-service-worker start",
               {
                 "ContainerPath": "/media-download",
                 "ReadOnly": false,
-                "SourceVolume": "media-download-volume",
+                "SourceVolume": "media-download-download-volume",
+              },
+              {
+                "ContainerPath": "/tmp",
+                "ReadOnly": false,
+                "SourceVolume": "media-download-temp-volume",
               },
             ],
             "Name": "media-download-task-TaskContainer",
@@ -2161,7 +2166,10 @@ service transcription-service-worker start",
         },
         "Volumes": [
           {
-            "Name": "media-download-volume",
+            "Name": "media-download-download-volume",
+          },
+          {
+            "Name": "media-download-temp-volume",
           },
         ],
       },

diff --git a/packages/cdk/lib/transcription-service.ts b/packages/cdk/lib/transcription-service.ts
@@ -737,15 +737,24 @@ export class TranscriptionService extends GuStack {
 			],
 		});
 
-		const volume = {
-			name: `${mediaDownloadApp}-volume`,
+		const downloadVolume = {
+			name: `${mediaDownloadApp}-download-volume`,
 		};
-		mediaDownloadTask.taskDefinition.addVolume(volume);
+		const tempVolume = {
+			name: `${mediaDownloadApp}-temp-volume`,
+		};
+		mediaDownloadTask.taskDefinition.addVolume(downloadVolume);
+		mediaDownloadTask.taskDefinition.addVolume(tempVolume);
 		mediaDownloadTask.containerDefinition.addMountPoints({
-			sourceVolume: volume.name,
+			sourceVolume: downloadVolume.name,
 			containerPath: '/media-download', // needs to match DOWNLOAD_DIRECTORY in media-download index.ts
 			readOnly: false,
 		});
+		mediaDownloadTask.containerDefinition.addMountPoints({
+			sourceVolume: tempVolume.name,
+			containerPath: '/tmp', // needed by yt-dlp
+			readOnly: false,
+		});
 
 		const pipeRole = new Role(this, 'eventbridge-pipe-role', {
 			assumedBy: new ServicePrincipal('pipes.amazonaws.com'),