Skip to content

Commit a2223b6

Browse files
committed
code review
1 parent 01e92fe commit a2223b6

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

elastic-sample/src/main/java/com/arcbees/gquery/elastic/htmlsample/public/ElasticLayoutSample.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est
3030
laborum
3131
</div>
32-
<div>2. Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et
33-
dolore
32+
<div data-elastic-row-span="all"><h3>data-elastic-rowspan="all"</h3>2. Lorem ipsum dolor sit amet, consectetur
33+
adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore
3434
magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo
3535
consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla
3636
pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est

elastic-sample/src/main/java/com/arcbees/gquery/elastic/widgetsample/client/WidgetSample.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616

1717
package com.arcbees.gquery.elastic.widgetsample.client;
1818

19-
import java.util.Random;
20-
2119
import com.arcbees.gquery.elastic.client.Elastic;
2220
import com.arcbees.gquery.elastic.client.ElasticHtmlPanel;
2321
import com.google.gwt.core.client.EntryPoint;
@@ -31,6 +29,8 @@
3129
import com.google.gwt.user.client.ui.ScrollPanel;
3230
import com.google.gwt.user.client.ui.Widget;
3331

32+
import java.util.Random;
33+
3434
public class WidgetSample implements EntryPoint {
3535
interface WidgetSampleUiBinder extends UiBinder<Widget, WidgetSample> {
3636
}

elastic/src/main/java/com/arcbees/gquery/elastic/client/ElasticHtmlPanel.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public void setMaximumColumnWidth(int maximumColumnWidth) {
9090
* If you want to the width of the columns doesn't increase with the width of the container, set the
9191
* <code>maximumWidth</code> equals to the <code>minimumWidth</code>
9292
* <p/>
93-
* If you want that the columns take all the available space in the container et increase their width according to
93+
* If you want that the columns take all the available space in the container and increase their width according to
9494
* the width of the container, set the <code>maximumWidth</code> to -1.
9595
* <p/>
9696
* Default: {@value -1}

elastic/src/main/java/com/arcbees/gquery/elastic/client/ElasticOption.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,12 @@ public int getMinimumColumnWidth() {
5353

5454
/**
5555
* Set the maximal width in px for a column. When the column width reach this value, the width of the column is not
56-
* increased even if the width od the container increase.
56+
* increased even if the width of the container increases.
5757
* <p/>
5858
* If you want to the width of the columns doesn't increase with the width of the container, set the
5959
* <code>maximumWidth</code> equals to the <code>minimumWidth</code>
6060
* <p/>
61-
* If you want that the columns take all the available space in the container et increase their width according to
61+
* If you want that the columns take all the available space in the container and increase their width according to
6262
* the width of the container, set the <code>maximumWidth</code> to -1.
6363
* <p/>
6464
* If the maximumColumnWidth value is be lower than the value returned by {@link #getMinimumColumnWidth()}, this

0 commit comments

Comments
 (0)