Skip to content

Commit 08ae591

Browse files
committed
Fix scala-js#124: Call quit not close on WebDriver for cleanup
1 parent 5372e7f commit 08ae591

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

seleniumJSEnv/src/main/scala/org/scalajs/jsenv/selenium/SeleniumRun.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ private[selenium] object SeleniumRun {
162162
}
163163

164164
private def maybeCleanupDriver(d: WebDriver, config: SeleniumJSEnv.Config) =
165-
if (!config.keepAlive) d.close()
165+
if (!config.keepAlive) d.quit()
166166

167167
private def htmlPage(fullInput: Seq[Input], materializer: FileMaterializer): String = {
168168
val tags = fullInput.map {

seleniumJSEnv/src/test/scala/org/scalajs/jsenv/selenium/KeepAliveTest.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class KeepAliveTest {
1818
private final class MockWebDriver extends WebDriver with JavascriptExecutor {
1919
var closed = false
2020

21-
def close(): Unit = closed = true
21+
def close(): Unit = ???
2222
def quit(): Unit = closed = true
2323

2424
def executeScript(code: String, args: Object*): Object =

0 commit comments

Comments
 (0)