Skip to content

Commit fb54ea8

Browse files
ndarilektimabbott
authored andcommitted
accessibility: Make the recipient row more accessible.
This primarily just exposes hidden icons.
1 parent ef8ea33 commit fb54ea8

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

static/templates/recipient_row.handlebars

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
title="{{#tr this}}Narrow to stream "__display_recipient__"{{/tr}}">
1010
{{! invite only lock }}
1111
{{#if invite_only}}
12-
<i class="fa fa-lock invite-stream-icon" aria-hidden="true" title="{{t 'This is a private stream' }}"></i>
12+
<i class="fa fa-lock invite-stream-icon" title="{{t 'This is a private stream' }}" aria-label="{{t 'This is a private stream' }}"></i>
1313
{{/if}}
1414
{{display_recipient}}
1515
</a>
@@ -34,24 +34,24 @@
3434
{{! exterior links (e.g. to a trac ticket) }}
3535
{{#each subject_links}}
3636
<a href="{{this}}" target="_blank" class="no-underline">
37-
<i class="fa fa-external-link-square" aria-hidden="true"></i>
37+
<i class="fa fa-external-link-square" aria-label="{{t 'External link' }}"></i>
3838
</a>
3939
{{/each}}
4040

4141
{{! edit subject pencil icon }}
4242
{{#if always_visible_topic_edit}}
43-
<i class="fa fa-pencil always_visible_topic_edit" aria-hidden="true" {{#unless realm_allow_message_editing}}style="display: none"{{/unless}}></i>
43+
<i class="fa fa-pencil always_visible_topic_edit" {{#unless realm_allow_message_editing}}style="display: none"{{/unless}} role="button" tabindex="0" aria-label="{{t 'Edit' }}"></i>
4444
{{else}}
4545
{{#if on_hover_topic_edit}}
46-
<i class="fa fa-pencil on_hover_topic_edit" aria-hidden="true" {{#unless realm_allow_message_editing}}style="display: none"{{/unless}}></i>
46+
<i class="fa fa-pencil on_hover_topic_edit" {{#unless realm_allow_message_editing}}style="display: none"{{/unless}} role="button" tabindex="0" aria-label="{{t 'Edit' }}"></i>
4747
{{/if}}
4848
{{/if}}
4949

5050
<span class="topic_edit">
5151
<span class="topic_edit_form" id="{{id}}"></span>
5252
</span>
5353

54-
<i class="fa fa-eye-slash on_hover_topic_mute" aria-hidden="true" data-stream-id="{{stream_id}}" data-topic-name="{{subject}}" title="{{t 'Mute topic' }} (M)"></i>
54+
<i class="fa fa-eye-slash on_hover_topic_mute" data-stream-id="{{stream_id}}" data-topic-name="{{subject}}" title="{{t 'Mute topic' }} (M)" role="button" tabindex="0" aria-label="{{t 'Mute topic' }} (M)"></i>
5555
<span class="recipient_row_date {{#if show_date}}{{else}}hide-date{{/if}}">{{{date}}}</span>
5656
</span>
5757
</div>

0 commit comments

Comments
 (0)