fix all eslint error

Author: a60814billy

lib/auth/index.ts

@@ -22,6 +22,7 @@ passport.deserializeUser(function (id, done) {
   }).then(function (user) {
     // Don't die on non-existent user
     if (user == null) {
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
       return done(null, false, {message: 'Invalid UserID'})
     }
@@ -34,18 +35,31 @@ passport.deserializeUser(function (id, done) {
   })
 })
 
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isFacebookEnable) authRouter.use(require('./facebook'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isTwitterEnable) authRouter.use(require('./twitter'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isGitHubEnable) authRouter.use(require('./github'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isBitbucketEnable) authRouter.use(require('./bitbucket'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isGitLabEnable) authRouter.use(require('./gitlab'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isMattermostEnable) authRouter.use(require('./mattermost'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isDropboxEnable) authRouter.use(require('./dropbox'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isGoogleEnable) authRouter.use(require('./google'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isLDAPEnable) authRouter.use(require('./ldap'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isSAMLEnable) authRouter.use(require('./saml'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isOAuth2Enable) authRouter.use(require('./oauth2'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isEmailEnable) authRouter.use(require('./email'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 if (config.isOpenIDEnable) authRouter.use(require('./openid'))
 
 // logout

lib/auth/ldap/index.ts

@@ -23,7 +23,7 @@ passport.use(new LDAPStrategy({
     tlsOptions: config.ldap.tlsOptions || null
   }
 }, function (user, done) {
-  var uuid = user.uidNumber || user.uid || user.sAMAccountName || undefined
+  let uuid = user.uidNumber || user.uid || user.sAMAccountName || undefined
   if (config.ldap.useridField && user[config.ldap.useridField]) {
     uuid = user[config.ldap.useridField]
   }
@@ -35,12 +35,12 @@ passport.use(new LDAPStrategy({
       '"useridField" option in ldap settings.')
   }
 
-  var username = uuid
+  let username = uuid
   if (config.ldap.usernameField && user[config.ldap.usernameField]) {
     username = user[config.ldap.usernameField]
   }
 
-  var profile = {
+  const profile = {
     id: 'LDAP-' + uuid,
     username: username,
     displayName: user.displayName,
@@ -49,7 +49,7 @@ passport.use(new LDAPStrategy({
     profileUrl: null,
     provider: 'ldap'
   }
-  var stringifiedProfile = JSON.stringify(profile)
+  const stringifiedProfile = JSON.stringify(profile)
   models.User.findOrCreate({
     where: {
       profileid: profile.id.toString()
@@ -59,7 +59,7 @@ passport.use(new LDAPStrategy({
     }
   }).spread(function (user, created) {
     if (user) {
-      var needSave = false
+      let needSave = false
       if (user.profile !== stringifiedProfile) {
         user.profile = stringifiedProfile
         needSave = true

lib/auth/openid/index.ts

@@ -16,7 +16,7 @@ passport.use(new OpenIDStrategy({
   realm: config.serverURL,
   profile: true
 }, function (openid, profile, done) {
-  var stringifiedProfile = JSON.stringify(profile)
+  const stringifiedProfile = JSON.stringify(profile)
   models.User.findOrCreate({
     where: {
       profileid: openid
@@ -26,7 +26,7 @@ passport.use(new OpenIDStrategy({
     }
   }).spread(function (user, created) {
     if (user) {
-      var needSave = false
+      let needSave = false
       if (user.profile !== stringifiedProfile) {
         user.profile = stringifiedProfile
         needSave = true

lib/auth/saml/index.ts

@@ -25,7 +25,7 @@ passport.use(new SamlStrategy({
 }, function (user, done) {
   // check authorization if needed
   if (config.saml.externalGroups && config.saml.groupAttribute) {
-    var externalGroups = intersection(config.saml.externalGroups, user[config.saml.groupAttribute])
+    const externalGroups = intersection(config.saml.externalGroups, user[config.saml.groupAttribute])
     if (externalGroups.length > 0) {
       logger.error('saml permission denied: ' + externalGroups.join(', '))
       return done('Permission denied', null)
@@ -38,8 +38,8 @@ passport.use(new SamlStrategy({
     }
   }
   // user creation
-  var uuid = user[config.saml.attribute.id] || user.nameID
-  var profile = {
+  const uuid = user[config.saml.attribute.id] || user.nameID
+  const profile = {
     provider: 'saml',
     id: 'SAML-' + uuid,
     username: user[config.saml.attribute.username] || user.nameID,
@@ -48,7 +48,7 @@ passport.use(new SamlStrategy({
   if (profile.emails.length === 0 && config.saml.identifierFormat === 'urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress') {
     profile.emails.push(user.nameID)
   }
-  var stringifiedProfile = JSON.stringify(profile)
+  const stringifiedProfile = JSON.stringify(profile)
   models.User.findOrCreate({
     where: {
       profileid: profile.id.toString()
@@ -58,7 +58,7 @@ passport.use(new SamlStrategy({
     }
   }).spread(function (user, created) {
     if (user) {
-      var needSave = false
+      let needSave = false
       if (user.profile !== stringifiedProfile) {
         user.profile = stringifiedProfile
         needSave = true

lib/auth/utils.ts

@@ -7,19 +7,19 @@ import * as logger from "../logger";
 export function setReturnToFromReferer(req) {
   if (!req.session) req.session = {}
 
-  var referer = req.get('referer')
-  var nextURL
+  const referer = req.get('referer')
+  let nextURL
   if (referer) {
     try {
-      var refererSearchParams = new URLSearchParams(new URL(referer).search)
+      const refererSearchParams = new URLSearchParams(new URL(referer).search)
       nextURL = refererSearchParams.get('next')
     } catch (err) {
       logger.warn(err)
     }
   }
 
   if (nextURL) {
-    var isRelativeNextURL = nextURL.indexOf('://') === -1 && !nextURL.startsWith('//')
+    const isRelativeNextURL = nextURL.indexOf('://') === -1 && !nextURL.startsWith('//')
     if (isRelativeNextURL) {
       req.session.returnTo = (new URL(nextURL, config.serverURL)).toString()
     } else {
@@ -31,7 +31,7 @@ export function setReturnToFromReferer(req) {
 }
 
 export function passportGeneralCallback(accessToken, refreshToken, profile, done) {
-  var stringifiedProfile = JSON.stringify(profile)
+  const stringifiedProfile = JSON.stringify(profile)
   models.User.findOrCreate({
     where: {
       profileid: profile.id.toString()
@@ -43,7 +43,7 @@ export function passportGeneralCallback(accessToken, refreshToken, profile, done
     }
   }).spread(function (user, created) {
     if (user) {
-      var needSave = false
+      let needSave = false
       if (user.profile !== stringifiedProfile) {
         user.profile = stringifiedProfile
         needSave = true

lib/config/index.ts

@@ -15,6 +15,7 @@ const debugConfig = {
 }
 
 // Get version string from package.json
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 const {version, repository} = require(path.join(appRootPath, 'package.json'))
 
 const commitID = getGitCommit(appRootPath)
@@ -30,14 +31,19 @@ const packageConfig = {
 
 const configFilePath = path.resolve(appRootPath, process.env.CMD_CONFIG_FILE ||
   'config.json')
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 const fileConfig = fs.existsSync(configFilePath) ? require(configFilePath)[env] : undefined
 
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 let config: any = require('./default')
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 merge(config, require('./defaultSSL'))
 merge(config, debugConfig)
 merge(config, packageConfig)
 merge(config, fileConfig)
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 merge(config, require('./environment'))
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 merge(config, require('./dockerSecret'))
 
 if (['debug', 'verbose', 'info', 'warn', 'error'].includes(config.loglevel)) {
@@ -86,9 +92,9 @@ config.isStandardHTTPPort = (function isStandardHTTPPort() {
 
 // cache serverURL
 config.serverURL = (function getserverurl() {
-  var url = ''
+  let url = ''
   if (config.domain) {
-    var protocol = config.protocolUseSSL ? 'https://' : 'http://'
+    const protocol = config.protocolUseSSL ? 'https://' : 'http://'
     url = protocol + config.domain
     if (config.urlAddPort) {
       if (!config.isStandardHTTPPort || !config.isStandardHTTPsPort) {

lib/config/utils.ts

@@ -8,7 +8,7 @@ export function toBooleanConfig(configValue) {
   return configValue
 }
 
-export function toArrayConfig(configValue, separator: string = ',', fallback ?: any) {
+export function toArrayConfig(configValue, separator = ',', fallback ?: any) {
   if (configValue && typeof configValue === 'string') {
     return (configValue.split(separator).map(arrayItem => arrayItem.trim()))
   }

lib/csp.ts

@@ -1,9 +1,9 @@
 import * as config from "./config";
 import * as uuid from "uuid";
 
-var CspStrategy: any = {}
+const CspStrategy: any = {}
 
-var defaultDirectives = {
+const defaultDirectives = {
   defaultSrc: ['\'self\''],
   scriptSrc: ['\'self\'', 'vimeo.com', 'https://gist.github.com', 'www.slideshare.net', 'https://query.yahooapis.com', '\'unsafe-eval\''],
   // ^ TODO: Remove unsafe-eval - webpack script-loader issues https://github.com/hackmdio/codimd/issues/594
@@ -16,28 +16,28 @@ var defaultDirectives = {
   connectSrc: ['*']
 }
 
-var dropboxDirectives = {
+const dropboxDirectives = {
   scriptSrc: ['https://www.dropbox.com']
 }
 
-var cdnDirectives = {
+const cdnDirectives = {
   scriptSrc: ['https://cdnjs.cloudflare.com', 'https://cdn.jsdelivr.net', 'https://cdn.mathjax.org'],
   styleSrc: ['https://cdnjs.cloudflare.com', 'https://cdn.jsdelivr.net', 'https://fonts.googleapis.com'],
   fontSrc: ['https://cdnjs.cloudflare.com', 'https://fonts.gstatic.com']
 }
 
-var disqusDirectives = {
+const disqusDirectives = {
   scriptSrc: ['https://disqus.com', 'https://*.disqus.com', 'https://*.disquscdn.com'],
   styleSrc: ['https://*.disquscdn.com'],
   fontSrc: ['https://*.disquscdn.com']
 }
 
-var googleAnalyticsDirectives = {
+const googleAnalyticsDirectives = {
   scriptSrc: ['https://www.google-analytics.com']
 }
 
 CspStrategy.computeDirectives = function () {
-  var directives = {}
+  const directives = {}
   mergeDirectives(directives, config.csp.directives)
   mergeDirectivesIf(config.csp.addDefaults, directives, defaultDirectives)
   mergeDirectivesIf(config.useCDN, directives, cdnDirectives)
@@ -53,10 +53,10 @@ CspStrategy.computeDirectives = function () {
 }
 
 function mergeDirectives(existingDirectives, newDirectives) {
-  for (var propertyName in newDirectives) {
-    var newDirective = newDirectives[propertyName]
+  for (const propertyName in newDirectives) {
+    const newDirective = newDirectives[propertyName]
     if (newDirective) {
-      var existingDirective = existingDirectives[propertyName] || []
+      const existingDirective = existingDirectives[propertyName] || []
       existingDirectives[propertyName] = existingDirective.concat(newDirective)
     }
   }
@@ -86,10 +86,10 @@ function getCspNonce(req, res) {
 function addUpgradeUnsafeRequestsOptionTo(directives) {
   if (config.csp.upgradeInsecureRequests === 'auto' && config.useSSL) {
     directives.upgradeInsecureRequests = true
-  } else { // @ts-ignore
+  } else {
     if (config.csp.upgradeInsecureRequests === true) {
-        directives.upgradeInsecureRequests = true
-      }
+      directives.upgradeInsecureRequests = true
+    }
   }
 }
 

lib/history/index.ts

@@ -16,7 +16,7 @@ function getHistory (userid, callback) {
     if (!user) {
       return callback(null, null)
     }
-    var history : [] | {} = []
+    let history: any = []
     if (user.history) {
       history = JSON.parse(user.history)
       // migrate LZString encoded note id to base64url encoded note id
@@ -78,8 +78,8 @@ export function updateHistory (userid, noteId, document?: string, time?: any) {
       if (!history[noteId]) {
         history[noteId] = {}
       }
-      var noteHistory = history[noteId]
-      var noteInfo = models.Note.parseNoteInfo(document)
+      const noteHistory = history[noteId]
+      const noteInfo = models.Note.parseNoteInfo(document)
       noteHistory.id = noteId
       noteHistory.text = noteInfo.title
       noteHistory.time = time || Date.now()
@@ -94,18 +94,18 @@ export function updateHistory (userid, noteId, document?: string, time?: any) {
 }
 
 function parseHistoryToArray (history) {
-  var _history = []
+  const _history = []
   Object.keys(history).forEach(function (key) {
-    var item = history[key]
+    const item = history[key]
     _history.push(item)
   })
   return _history
 }
 
 function parseHistoryToObject (history) {
-  var _history = {}
-  for (var i = 0, l = history.length; i < l; i++) {
-    var item = history[i]
+  const _history = {}
+  for (let i = 0, l = history.length; i < l; i++) {
+    const item = history[i]
     _history[item.id] = item
   }
   return _history
@@ -127,12 +127,13 @@ export function historyGet (req, res) {
 
 export function historyPost (req, res) {
   if (req.isAuthenticated()) {
-    var noteId = req.params.noteId
+    const noteId = req.params.noteId
     if (!noteId) {
       if (typeof req.body.history === 'undefined') return response.errorBadRequest(req, res)
       if (config.debug) { logger.info('SERVER received history from [' + req.user.id + ']: ' + req.body.history) }
+      let history = null
       try {
-        var history = JSON.parse(req.body.history)
+        history = JSON.parse(req.body.history)
       } catch (err) {
         return response.errorBadRequest(req, res)
       }
@@ -168,7 +169,7 @@ export function historyPost (req, res) {
 
 export function historyDelete (req, res) {
   if (req.isAuthenticated()) {
-    var noteId = req.params.noteId
+    const noteId = req.params.noteId
     if (!noteId) {
       setHistory(req.user.id, [], function (err, count) {
         if (err) return response.errorInternalError(req, res)

lib/homepage/index.ts

@@ -1,6 +1,7 @@
 import * as fs from 'fs'
 import * as path from 'path'
 import * as config from '../config'
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
 import {User} from '../models'
 import * as logger from '../logger'

lib/imageRouter/azure.ts

@@ -17,7 +17,7 @@ export function uploadImage(imagePath, callback) {
     return
   }
 
-  var azureBlobService = azure.createBlobService(config.azure.connectionString)
+  const azureBlobService = azure.createBlobService(config.azure.connectionString)
 
   azureBlobService.createContainerIfNotExists(config.azure.container, {publicAccessLevel: 'blob'}, function (err, result, response) {
     if (err) {