Hints for Netcode for Gameobjects + VContainer | Missing injection in network objects

[ModischFabrications]

This might be interesting for the wiki and/or readme as well, feel free to move if so. I have stumbled a few times already looking for hints on Netcode for Gameobjects (NGO) + VContainer. This is my attempt to help newcomers like me.

Problem

Dynamically network/client-side spawned gameobjects will not have any injection, because they are instantiated by the networking solution of NGO.

Solution

Find the container and request injection manually.

#357 has a basic version for this, but GetComponentInParent will rarely work for network-spawned objects, because client-side spawned objects are usually in the root instead of being a child of the scope.

FindAnyObjectByType<LifetimeScope>() is a naive alternative, but will find scopes from other scenes, which could be a problem for bootstrapped ones.

I found two options that are valid for me and did some simple benchmarks in the editor:

---

Option A (x100) (works only if the scope is a root objects in the scene, which it usually is for me)

var rootObjects = gameObject.scene.GetRootGameObjects();

// option A
foreach (var obj in rootObjects)
{
    var scope = obj.GetComponent<LifetimeScope>();
    if (scope != null)
        return scope;
}

throw new ArgumentException("Can't find container");

Option B (x100)

return FindObjectsByType<LifetimeScope>(FindObjectsInactive.Exclude, FindObjectsSortMode.None)
                .First(s => s.gameObject.scene == gameObject.scene);

=> In summary: Search in root components if you have the option, look everywhere if you need more safety. Both should be fine to run every once in a while. Try not to do this every frame, it's expensive!

[wintbiit]

My solution here is: the lifetime scope that should inject dynamically generated objects do not directly inherit from LifetimeScope. Instead, declare a some abstract GameLifetimeScope: LifetimeScope and then just call FindAnyObjectByType<GameLifetimeScope> works just fine.