Skip to content

Commit f535004

Browse files
committed
[SPARK-31967][UI] Downgrade to vis.js 4.21.0 to fix Jobs UI loading time regression
### What changes were proposed in this pull request? After apache#28192, the job list page becomes very slow. For example, after the following operation, the UI loading can take >40 sec. ``` (1 to 1000).foreach(_ => sc.parallelize(1 to 10).collect) ``` This is caused by a [performance issue of `vis-timeline`](visjs/vis-timeline#379). The serious issue affects both branch-3.0 and branch-2.4 I tried a different version 4.21.0 from https://cdnjs.com/libraries/vis The infinite drawing issue seems also fixed if the zoom is disabled as default. ### Why are the changes needed? Fix the serious perf issue in web UI by falling back vis-timeline-graph2d to an ealier version. ### Does this PR introduce _any_ user-facing change? Yes, fix the UI perf regression ### How was this patch tested? Manual test Closes apache#28806 from gengliangwang/downgradeVis. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
1 parent a620a2a commit f535004

7 files changed

+49
-86
lines changed

core/src/main/resources/org/apache/spark/ui/static/vis-timeline-graph2d.min.css

+1-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/src/main/resources/org/apache/spark/ui/static/vis-timeline-graph2d.min.css.map

-1
This file was deleted.

core/src/main/resources/org/apache/spark/ui/static/vis-timeline-graph2d.min.js

+20-50
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/src/main/resources/org/apache/spark/ui/static/vis-timeline-graph2d.min.js.map

-1
This file was deleted.

dev/.rat-excludes

-2
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,7 @@ dagre-d3.min.js
3131
graphlib-dot.min.js
3232
sorttable.js
3333
vis-timeline-graph2d.min.js
34-
vis-timeline-graph2d.min.js.map
3534
vis-timeline-graph2d.min.css
36-
vis-timeline-graph2d.min.css.map
3735
dataTables.bootstrap4.1.10.20.min.css
3836
dataTables.bootstrap4.1.10.20.min.js
3937
dataTables.rowsGroup.js
+14-15
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,22 @@
1-
vis-timeline and vis-graph2d
2-
https://visjs.github.io/vis-timeline/
1+
vis.js
2+
https://github.com/almende/vis
33

4-
Create a fully customizable, interactive timeline with items and ranges.
4+
A dynamic, browser-based visualization library.
55

6-
@version 7.3.4
7-
@date 2020-03-18T17:03:58.105Z
8-
9-
@copyright (c) 2011-2017 Almende B.V, http://almende.com
10-
@copyright (c) 2017-2019 visjs contributors, https://github.com/visjs
6+
@version 4.20.1-SNAPSHOT
7+
@date 2017-10-12
118

129
@license
13-
vis.js is dual licensed under both
10+
Copyright (C) 2011-2017 Almende B.V, http://almende.com
11+
12+
Vis.js is dual licensed under both
1413

15-
1. The Apache 2.0 License
16-
http://www.apache.org/licenses/LICENSE-2.0
14+
* The Apache 2.0 License
15+
http://www.apache.org/licenses/LICENSE-2.0
1716

18-
and
17+
and
1918

20-
2. The MIT License
21-
http://opensource.org/licenses/MIT
19+
* The MIT License
20+
http://opensource.org/licenses/MIT
2221

23-
vis.js may be distributed under either license.
22+
Vis.js may be distributed under either license.

licenses/LICENSE-vis-timeline.txt

+14-15
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,22 @@
1-
vis-timeline and vis-graph2d
2-
https://visjs.github.io/vis-timeline/
1+
vis.js
2+
https://github.com/almende/vis
33

4-
Create a fully customizable, interactive timeline with items and ranges.
4+
A dynamic, browser-based visualization library.
55

6-
@version 7.3.4
7-
@date 2020-03-18T17:03:58.105Z
8-
9-
@copyright (c) 2011-2017 Almende B.V, http://almende.com
10-
@copyright (c) 2017-2019 visjs contributors, https://github.com/visjs
6+
@version 4.20.1-SNAPSHOT
7+
@date 2017-10-12
118

129
@license
13-
vis.js is dual licensed under both
10+
Copyright (C) 2011-2017 Almende B.V, http://almende.com
11+
12+
Vis.js is dual licensed under both
1413

15-
1. The Apache 2.0 License
16-
http://www.apache.org/licenses/LICENSE-2.0
14+
* The Apache 2.0 License
15+
http://www.apache.org/licenses/LICENSE-2.0
1716

18-
and
17+
and
1918

20-
2. The MIT License
21-
http://opensource.org/licenses/MIT
19+
* The MIT License
20+
http://opensource.org/licenses/MIT
2221

23-
vis.js may be distributed under either license.
22+
Vis.js may be distributed under either license.

0 commit comments

Comments
 (0)