Skip to content

Update to Webpack 2 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jackfranklin opened this issue Nov 30, 2016 · 5 comments · Fixed by #95
Closed

Update to Webpack 2 #71

jackfranklin opened this issue Nov 30, 2016 · 5 comments · Fixed by #95
Labels
feature A feature request good first issue

Comments

@jackfranklin
Copy link
Contributor

It's in beta but very stable - I've used it on numerous projects and not had issues; and it's not a huge amount of change.

Would you be happy with a PR if I found the time to make it? :)
@halfzebra
Copy link
Owner

halfzebra commented Dec 1, 2016 •
edited
Loading

@jackfranklin I'm using it myself, there are a couple reasons why Create Elm App does not rely on it yet.

First of all, it's create-react-app/issues/183, on top of that we will won't get any benefits from tree-shaking.

It looks like react-dev-utils/webpackHotDevClient is compatible with webpack 2 already.

I would give it a go! 😃

@jackfranklin
Copy link
Contributor Author

Do you mean that webpackHotDevClient isn't compatible with webpack 2, or that it is? Sorry; I'm a bit confused!

Maybe it is best to hold off for a bit; I might work on the PR anyway for when the time comes! :)

@halfzebra
Copy link
Owner

@jackfranklin Sorry, that was some wierd phrasing from me 😄

webpackHotDevClient is compatible with webpack 2, it would be awesome if you gave it a shot at upgrading Create Elm App to use it!

@jackfranklin
Copy link
Contributor Author

👍 I'll try to but if anyone beats me to it I won't mind! :D

@halfzebra halfzebra added the feature A feature request label Dec 3, 2016
@jackfranklin
Copy link
Contributor Author

@halfzebra going to revisit this soon now Webpack 2.2 is out as a beta. Just giving all the other Webpack packages time to catch up and then I'll get on this :)

Lodin added a commit to Lodin/create-elm-app that referenced this issue Feb 1, 2017
@Lodin
build(webpack): update webpack to version 2.2.1
e29cbe4 
update webpack to version 2.2.1, update all dependencies to the newest versions, fix es6-es5 mixed
style, fix displaying compilation errors

closes halfzebra#71
@Lodin Lodin mentioned this issue Feb 1, 2017
Merged
Lodin added a commit to Lodin/create-elm-app that referenced this issue Feb 10, 2017
@Lodin
build(webpack): update webpack to version 2.2.1
34b7020 
update webpack to version 2.2.1, update all dependencies to the newest versions, fix es6-es5 mixed
style, fix displaying compilation errors

closes halfzebra#71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A feature request good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(webpack): update webpack to version 2.2.1 Lodin/create-elm-app
2 participants
@jackfranklin @halfzebra