Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Housekeeping/General] Consider migrating to Typescript #86

Open
asvetliakov opened this issue Apr 14, 2016 · 2 comments
Open

[Housekeeping/General] Consider migrating to Typescript #86

asvetliakov opened this issue Apr 14, 2016 · 2 comments

Comments

@asvetliakov
Copy link
Collaborator

After supporting object spread: microsoft/TypeScript#2103

Pros:

  • Easier refactoring
  • No need to sync props with separate ts definition
  • Easy to move on
  • Completion in editor

Additional efforts

  • Investigate and add support for TS types into react-docgen
  • Remove react prop types from components?
@Asgator
Copy link
Contributor

Asgator commented Jul 15, 2016 •
edited
Loading

May use https://flowtype.org/ ?

@ghost
Copy link

ghost commented Aug 15, 2016

This would make it more difficult to anyone not familiar with typescript to contribute. Whereas you can count on anyone using react to know js. You'd be looking at a lot less possible contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Asgator @asvetliakov