Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit f2fd2d8

Browse files
woz5999actions-bot
andauthoredDec 15, 2020
update context and tf .14 support (cloudposse#95)
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
1 parent 0f2c773 commit f2fd2d8

File tree

7 files changed

+36
-13
lines changed

7 files changed

+36
-13
lines changed
 

‎README.md

+10-3
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,15 @@ We literally have [*hundreds of terraform modules*][terraform_modules] that are
6464
## Usage
6565

6666

67-
**IMPORTANT:** The `master` branch is used in `source` just as an example. In your code, do not pin to `master` because there may be breaking changes between releases.
68-
Instead pin to the release tag (e.g. `?ref=tags/x.y.z`) of one of our [latest releases](https://github.com/cloudposse/terraform-aws-elasticache-redis/releases).
67+
**IMPORTANT:** We do not pin modules to versions in our examples because of the
68+
difficulty of keeping the versions in the documentation in sync with the latest released versions.
69+
We highly recommend that in your code you pin the version to the exact version you are
70+
using so that your infrastructure remains stable, and update versions in a
71+
systematic way so that they do not catch you by surprise.
72+
73+
Also, because of a bug in the Terraform registry ([hashicorp/terraform#21417](https://github.com/hashicorp/terraform/issues/21417)),
74+
the registry shows many of our inputs as required when in fact they are optional.
75+
The table below correctly indicates which inputs are required.
6976

7077

7178

@@ -153,7 +160,7 @@ Available targets:
153160

154161
| Name | Version |
155162
|------|---------|
156-
| terraform | >= 0.12.0 |
163+
| terraform | >= 0.12.26 |
157164
| aws | >= 2.0 |
158165
| null | >= 2.0 |
159166

‎context.tf

+3-1
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,10 @@
1818
# will be null, and `module.this.delimiter` will be `-` (hyphen).
1919
#
2020

21+
2122
module "this" {
22-
source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.19.2"
23+
source = "cloudposse/label/null"
24+
version = "0.22.0" // requires Terraform >= 0.12.26
2325

2426
enabled = var.enabled
2527
namespace = var.namespace

‎docs/terraform.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
| Name | Version |
55
|------|---------|
6-
| terraform | >= 0.12.0 |
6+
| terraform | >= 0.12.26 |
77
| aws | >= 2.0 |
88
| null | >= 2.0 |
99

‎examples/complete/context.tf

+3-1
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,10 @@
1818
# will be null, and `module.this.delimiter` will be `-` (hyphen).
1919
#
2020

21+
2122
module "this" {
22-
source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.19.2"
23+
source = "cloudposse/label/null"
24+
version = "0.22.0" // requires Terraform >= 0.12.26
2325

2426
enabled = var.enabled
2527
namespace = var.namespace

‎examples/complete/versions.tf

+9-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
11
terraform {
2-
required_version = ">= 0.12.0"
2+
required_version = ">= 0.12.26"
33

44
required_providers {
5-
aws = ">= 2.0"
6-
null = ">= 2.0"
5+
aws = {
6+
source = "hashicorp/aws"
7+
version = ">= 2.0"
8+
}
9+
null = {
10+
source = "hashicorp/null"
11+
version = ">= 2.0"
12+
}
713
}
814
}

‎main.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ resource "aws_cloudwatch_metric_alarm" "cache_memory" {
159159
}
160160

161161
module "dns" {
162-
source = "git::https://github.com/cloudposse/terraform-aws-route53-cluster-hostname.git?ref=tags/0.7.0"
162+
source = "git::https://github.com/cloudposse/terraform-aws-route53-cluster-hostname.git?ref=tags/0.8.0"
163163

164164
enabled = module.this.enabled && var.zone_id != "" ? true : false
165165
dns_name = var.dns_subdomain != "" ? var.dns_subdomain : module.this.id

‎versions.tf

+9-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
11
terraform {
2-
required_version = ">= 0.12.0"
2+
required_version = ">= 0.12.26"
33

44
required_providers {
5-
aws = ">= 2.0"
6-
null = ">= 2.0"
5+
aws = {
6+
source = "hashicorp/aws"
7+
version = ">= 2.0"
8+
}
9+
null = {
10+
source = "hashicorp/null"
11+
version = ">= 2.0"
12+
}
713
}
814
}

0 commit comments

Comments
 (0)
Please sign in to comment.