Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assigned but unused variables #112

Closed
justin-rhoades opened this issue Jun 5, 2016 · 2 comments
Closed

Assigned but unused variables #112

justin-rhoades opened this issue Jun 5, 2016 · 2 comments
Assignees
@jodosha

Comments

@justin-rhoades
Copy link

When running tests in router and in Hanami, there are two warnings for assigned but unused variables.

/.rvm/gems/ruby-2.3.1/gems/http_router-0.11.2/lib/http_router/generator.rb:58: warning: assigned but unused variable - generator

  • This may be here for clarification purposes

and

/.rvm/gems/ruby-2.3.1/gems/http_router-0.11.2/lib/http_router/route_helper.rb:99: warning: assigned but unused variable - params

  • Does not appear this variable is used at all in the method, could be removed?

Could definitely easily fix this if there is no reasoning for having the variables. Let me know!
@justin-rhoades justin-rhoades changed the title Assigned but unused variable methods Assigned but unused variables Jun 5, 2016
@justin-rhoades
Copy link
Author

Wow never mind. This was totally my bad, too early in the morning. Obviously this is an issue with the http_router gem -_-

@jodosha jodosha self-assigned this Jun 7, 2016
@jodosha
Copy link
Member

jodosha commented Jun 7, 2016

@justin-rhoades There is an open PR in http_router repository. Maybe you can upvote it. Thanks! joshbuddy/http_router#47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodosha jodosha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jodosha @justin-rhoades