Skip to content

Commit 645ac73

Browse files
nknappErisDS
authored andcommitted
test: fix integration tests
- They should fail, if any test fails - Use "set -e" instead of "|| exit 1", because it suffices to be specified at the top of each file
1 parent b454b02 commit 645ac73

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

integration-testing/multi-nodejs-test/test.sh

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
#!/bin/bash
22

3+
set -e
4+
35
cd "$( dirname "$( readlink -f "$0" )" )" || exit 1
46
# shellcheck disable=SC1090
57
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
@@ -20,8 +22,8 @@ for i in 0.10 0.12 4 5 6 7 8 9 10 11 ; do
2022
mkdir target
2123
nvm install "$i"
2224
nvm exec "$i" npm install
23-
nvm exec "$i" npm run test || exit 1
24-
nvm exec "$i" npm run test-precompile || exit 1
25+
nvm exec "$i" npm run test
26+
nvm exec "$i" npm run test-precompile
2527

2628
echo Success
2729
done
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
#!/bin/bash
22

3-
cd "$( dirname "$( readlink -f "$0" )" )" || exit 1
3+
set -e
4+
5+
cd "$( dirname "$( readlink -f "$0" )" )"
46

57
for i in */test.sh ; do
68
(
79
echo "----------------------------------------"
810
echo "-- Running integration test: $i"
911
echo "----------------------------------------"
10-
cd "$( dirname "$i" )" || exit 1
11-
./test.sh || exit 1
12+
cd "$( dirname "$i" )"
13+
./test.sh
1214
)
13-
done
15+
done

package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)