Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: HelloVerifyRequest parsing #191

Open
hanno-becker opened this issue Apr 15, 2021 · 1 comment
Open

Review: HelloVerifyRequest parsing #191

hanno-becker opened this issue Apr 15, 2021 · 1 comment

Comments

@hanno-becker
Copy link
Collaborator

This issue it to track the review and potential rework of the client-side HelloVerifyRequest state in preparation for upstreaming.

Things to look for:

  • Security
  • Functional correctness
  • Clarity of code and information flow
  • Adherence to Mbed TLS style

Acceptance criteria: One or more PRs improving on the above points to the satisfaction of the team, or a confirmation of review with the result that no changes were necessary.

@hanno-becker
Copy link
Collaborator Author

hanno-becker commented Apr 20, 2021

#102 by @gbryant-arm should be reviewed and merged prior to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant