Skip to content

Commit 1720a25

Browse files
author
Eugen Freiter
committed
add constants for default min/max values
Signed-off-by: Eugen Freiter <[email protected]>
1 parent 7fcc492 commit 1720a25

File tree

4 files changed

+37
-4
lines changed

4 files changed

+37
-4
lines changed

src/main/java/io/github/hapjava/characteristics/impl/thermostat/CoolingThresholdTemperatureCharacteristic.java

+11-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
* This characteristic describes the cooling threshold on which accessories turns on the cooling.
1313
*/
1414
public class CoolingThresholdTemperatureCharacteristic extends FloatCharacteristic {
15+
public static final double DEFAULT_MIN_VALUE = 10;
16+
public static final double DEFAULT_MAX_VALUE = 35;
17+
public static final double DEFAULT_STEP = 0.1;
1518

1619
public CoolingThresholdTemperatureCharacteristic(
1720
double minValue,
@@ -39,6 +42,13 @@ public CoolingThresholdTemperatureCharacteristic(
3942
ExceptionalConsumer<Double> setter,
4043
Consumer<HomekitCharacteristicChangeCallback> subscriber,
4144
Runnable unsubscriber) {
42-
this(10, 35, 0.1, getter, setter, subscriber, unsubscriber);
45+
this(
46+
DEFAULT_MIN_VALUE,
47+
DEFAULT_MAX_VALUE,
48+
DEFAULT_STEP,
49+
getter,
50+
setter,
51+
subscriber,
52+
unsubscriber);
4353
}
4454
}

src/main/java/io/github/hapjava/characteristics/impl/thermostat/CurrentTemperatureCharacteristic.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99

1010
/** characteristic describes the current temperature of the environment in Celsius */
1111
public class CurrentTemperatureCharacteristic extends FloatCharacteristic {
12+
public static final double DEFAULT_MIN_VALUE = 0;
13+
public static final double DEFAULT_MAX_VALUE = 100;
14+
public static final double DEFAULT_STEP = 0.1;
1215

1316
public CurrentTemperatureCharacteristic(
1417
double minValue,
@@ -34,6 +37,6 @@ public CurrentTemperatureCharacteristic(
3437
Supplier<CompletableFuture<Double>> getter,
3538
Consumer<HomekitCharacteristicChangeCallback> subscriber,
3639
Runnable unsubscriber) {
37-
this(0, 100, 0.1, getter, subscriber, unsubscriber);
40+
this(DEFAULT_MIN_VALUE, DEFAULT_MAX_VALUE, DEFAULT_STEP, getter, subscriber, unsubscriber);
3841
}
3942
}

src/main/java/io/github/hapjava/characteristics/impl/thermostat/HeatingThresholdTemperatureCharacteristic.java

+11-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010

1111
/** This characteristic describes the heating threshold on which heating get turned on. */
1212
public class HeatingThresholdTemperatureCharacteristic extends FloatCharacteristic {
13+
public static final double DEFAULT_MIN_VALUE = 0;
14+
public static final double DEFAULT_MAX_VALUE = 25;
15+
public static final double DEFAULT_STEP = 0.1;
1316

1417
public HeatingThresholdTemperatureCharacteristic(
1518
double minValue,
@@ -37,6 +40,13 @@ public HeatingThresholdTemperatureCharacteristic(
3740
ExceptionalConsumer<Double> setter,
3841
Consumer<HomekitCharacteristicChangeCallback> subscriber,
3942
Runnable unsubscriber) {
40-
this(0, 25, 0.1, getter, setter, subscriber, unsubscriber);
43+
this(
44+
DEFAULT_MIN_VALUE,
45+
DEFAULT_MAX_VALUE,
46+
DEFAULT_STEP,
47+
getter,
48+
setter,
49+
subscriber,
50+
unsubscriber);
4151
}
4252
}

src/main/java/io/github/hapjava/characteristics/impl/thermostat/TargetTemperatureCharacteristic.java

+11-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313
* attempting to reach.
1414
*/
1515
public class TargetTemperatureCharacteristic extends FloatCharacteristic {
16+
public static final double DEFAULT_MIN_VALUE = 10;
17+
public static final double DEFAULT_MAX_VALUE = 38;
18+
public static final double DEFAULT_STEP = 0.1;
1619

1720
public TargetTemperatureCharacteristic(
1821
double minValue,
@@ -40,6 +43,13 @@ public TargetTemperatureCharacteristic(
4043
ExceptionalConsumer<Double> setter,
4144
Consumer<HomekitCharacteristicChangeCallback> subscriber,
4245
Runnable unsubscriber) {
43-
this(10, 38, 0.1, getter, setter, subscriber, unsubscriber);
46+
this(
47+
DEFAULT_MIN_VALUE,
48+
DEFAULT_MAX_VALUE,
49+
DEFAULT_STEP,
50+
getter,
51+
setter,
52+
subscriber,
53+
unsubscriber);
4454
}
4555
}

0 commit comments

Comments
 (0)