incorporate review feedback

Eugen Freiter · Eugen Freiter · commit c80f3e71d9bd · 2020-12-09T21:58:23.000+01:00
Signed-off-by: Eugen Freiter &lt;freiter@gmx.de&gt;
diff --git a/src/main/java/io/github/hapjava/server/impl/crypto/HAPSetupCodeUtils.java b/src/main/java/io/github/hapjava/server/impl/crypto/HAPSetupCodeUtils.java
@@ -17,13 +17,7 @@ public static String randomAlphaNumeric(int count) {
   }
 
   public static String generateSetupId() {
-    String setupId =
-        ""
-            + ALPHA_NUMERIC_STRING.charAt((int) (Math.random() * ALPHA_NUMERIC_STRING.length()))
-            + ALPHA_NUMERIC_STRING.charAt((int) (Math.random() * ALPHA_NUMERIC_STRING.length()))
-            + ALPHA_NUMERIC_STRING.charAt((int) (Math.random() * ALPHA_NUMERIC_STRING.length()))
-            + ALPHA_NUMERIC_STRING.charAt((int) (Math.random() * ALPHA_NUMERIC_STRING.length()));
-    return setupId;
+    return randomAlphaNumeric(4);
   }
 
   private static byte[] calculateHash(final String input, final Digest digest) {

Original file line number	Diff line number	Diff line change
`@@ -17,13 +17,7 @@ public static String randomAlphaNumeric(int count) {`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`public static String generateSetupId() {`
`20`		`- String setupId =`
`21`		`- ""`
`22`		`- + ALPHA_NUMERIC_STRING.charAt((int) (Math.random() * ALPHA_NUMERIC_STRING.length()))`
`23`		`- + ALPHA_NUMERIC_STRING.charAt((int) (Math.random() * ALPHA_NUMERIC_STRING.length()))`
`24`		`- + ALPHA_NUMERIC_STRING.charAt((int) (Math.random() * ALPHA_NUMERIC_STRING.length()))`
`25`		`- + ALPHA_NUMERIC_STRING.charAt((int) (Math.random() * ALPHA_NUMERIC_STRING.length()));`
`26`		`- return setupId;`
	`20`	`+ return randomAlphaNumeric(4);`
`27`	`21`	`}`
`28`	`22`
`29`	`23`	`private static byte[] calculateHash(final String input, final Digest digest) {`