fix the comparison for quorum check in uniformVoteWeight

GheisMohammadi · GheisMohammadi · commit de4b8bcf2d5d · 2025-01-28T10:32:42.000+08:00
diff --git a/consensus/quorum/one-node-one-vote.go b/consensus/quorum/one-node-one-vote.go
@@ -62,9 +62,9 @@ func (v *uniformVoteWeight) IsQuorumAchievedByMask(mask *bls_cosi.Mask) bool {
 	}
 	threshold := v.TwoThirdsSignersCount()
 	currentTotalPower := utils.CountOneBits(mask.Bitmap)
-	enoughVotingPower := currentTotalPower >= threshold
+	enoughVotingPower := threshold >= currentTotalPower 
 	if v.useGTforQuorumChecking {
-		enoughVotingPower = currentTotalPower > threshold
+		enoughVotingPower = threshold > currentTotalPower 
 	}
 	if !enoughVotingPower {
 		const msg = "[IsQuorumAchievedByMask] Not enough voting power: need %+v, have %+v"

Original file line number	Diff line number	Diff line change
`@@ -62,9 +62,9 @@ func (v uniformVoteWeight) IsQuorumAchievedByMask(mask bls_cosi.Mask) bool {`
`62`	`62`	`}`
`63`	`63`	`threshold := v.TwoThirdsSignersCount()`
`64`	`64`	`currentTotalPower := utils.CountOneBits(mask.Bitmap)`
`65`		`- enoughVotingPower := currentTotalPower >= threshold`
	`65`	`+ enoughVotingPower := threshold >= currentTotalPower`
`66`	`66`	`if v.useGTforQuorumChecking {`
`67`		`- enoughVotingPower = currentTotalPower > threshold`
	`67`	`+ enoughVotingPower = threshold > currentTotalPower`
`68`	`68`	`}`
`69`	`69`	`if !enoughVotingPower {`
`70`	`70`	`const msg = "[IsQuorumAchievedByMask] Not enough voting power: need %+v, have %+v"`