Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade winning token on Uniswap and inspect stats using an embedded widget, without leaving the website #15

Open
polymorpher opened this issue Dec 22, 2024 · 2 comments

Comments

@polymorpher
Copy link

The trading experience of new tokens is poor on Uniswap - a warning is prompted, tokens names get cut off, and icons / images are not displayed. There is also no simple way to find out the liquidity and transaction history of the tokens on Uniswap interface.

We can provide much better trading experience on our website - after a token becomes tradable on Uniswap, show the embedded the swap boxes at the place originally for buying/selling the token. On the same web page in trading history tab, we should also transactions performed via Uniswap / embedded widget. Additionally, the remaining balance of the pool, current price, and time-weighted average price should be displayed promptly on the page

@ArtemKolodko
Copy link
Collaborator

ArtemKolodko commented Dec 22, 2024

swap.country / Uniswap quote and trade logic is pretty complex and require a lot of effort to integrate in another app; I was working on similar task before while working on Harmony Portfolio.

Alternative solutions:

  1. Since we control swap.country source code, it would be much easier to integrate it with pump.one: add images and remove warning notification for tokens minted by pump.one TokenFactory contract

  2. Fork Uniswap swap widget, integrate it with our swap.country and add to pump.one client. Require some research - is it compatible with Uniswap version we are using in swap.country? Hard to estimate it right now.

Option 1 looks preferable for me: it will require around 2 days to implement and will fix most user problems. Later we can explore widget integration.

@polymorpher
Copy link
Author

polymorpher commented Dec 23, 2024

The widget seems compatible and configurable https://docs.uniswap.org/sdk/swap-widget/reference/v2, let's find out more

https://github.com/Uniswap/widgets-demo/tree/cra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants