FFM-6964 - Add broader exception handling in case authentication fails (

#137)

Also only wait for 5 seconds instead of forever, allowing the failure check to proppogate

src/main/java/io/harness/cf/client/api/AuthCallback.java

@@ -2,4 +2,6 @@
 
 interface AuthCallback {
   void onAuthSuccess();
+
+  void onFailure(final String message);
 }

src/main/java/io/harness/cf/client/api/AuthService.java

@@ -33,10 +33,16 @@ protected void runOneIteration() {
       stopAsync();
       log.info("Stopping Auth service");
     } catch (ConnectorException e) {
-      log.error(
-          "Exception while authenticating, retry in {} seconds, error: {}",
-          pollIntervalInSec,
-          e.getMessage());
+      if (e.shouldRetry()) {
+        log.error(
+            "Exception while authenticating, retry in {} seconds, error: {}",
+            pollIntervalInSec,
+            e.getMessage());
+      } else {
+        stopAsync();
+        log.error("Exception while authenticating", e);
+        callback.onFailure(e.getMessage());
+      }
     }
   }
 

src/main/java/io/harness/cf/client/api/InnerClient.java

@@ -335,7 +335,7 @@ public synchronized void waitForInitialization()
       throws InterruptedException, FeatureFlagInitializeException {
     while (!initialized) {
       log.info("Wait for initialization to finish");
-      wait();
+      wait(5000);
 
       if (failure) {
         log.error("Failure while initializing SDK!");

src/main/java/io/harness/cf/client/connector/ConnectorException.java

@@ -3,18 +3,33 @@
 public class ConnectorException extends Exception {
 
   private final int httpCode;
+  private final boolean shouldRetry;
+
   private final String httpReason;
 
   public ConnectorException(String message) {
     super(message);
     this.httpCode = 0;
     this.httpReason = "";
+    this.shouldRetry = true;
   }
 
   public ConnectorException(String message, int httpCode, String httpMsg) {
     super(message);
     this.httpCode = httpCode;
     this.httpReason = httpMsg;
+    this.shouldRetry = true;
+  }
+
+    public ConnectorException(String message, boolean shouldRetry, Exception e) {
+    super(message, e);
+    this.shouldRetry = shouldRetry;
+    this.httpCode = 0;
+    this.httpReason = "";
+  }
+
+  public boolean shouldRetry() {
+    return shouldRetry;
   }
 
   @Override