From 98f8f3e727008cf2a91c97f604535aa42686a0e9 Mon Sep 17 00:00:00 2001
From: Andrew Bell <115623869+andybharness@users.noreply.github.com>
Date: Fri, 25 Nov 2022 16:00:31 +0000
Subject: [PATCH] [FFM-5247] Fix Jacoco code coverage report (#124)

What
Fix the Jacoco code coverage plugin to correctly generate coverage reports. Surefire plugin will stomp over the command line arguments needed by Jacoco and they need to be preserved with some additional configuration.

Why
We want to be able to generate Jacoco code coverage reports so that downstream pipelines can consume coverage information for better reporting

Testing
Confirmed target/jacoco.exec and ./target/site/jacoco/index.html exists after building via cmd line
---
 pom.xml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 24d33819..e8cffcae 100644
--- a/pom.xml
+++ b/pom.xml
@@ -398,20 +398,22 @@
                     <statelessTestsetReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5Xml30StatelessReporter">
                         <usePhrasedTestCaseMethodName>true</usePhrasedTestCaseMethodName>
                     </statelessTestsetReporter>
+                    <argLine>${surefireArgLine} -Xmx1024m -noverify</argLine>
                 </configuration>
             </plugin>
             <plugin>
                 <groupId>org.jacoco</groupId>
                 <artifactId>jacoco-maven-plugin</artifactId>
-                <version>0.8.7</version>
+                <version>0.8.8</version>
                 <executions>
                     <execution>
+                        <id>default-prepare-agent</id>
                         <goals>
                             <goal>prepare-agent</goal>
                         </goals>
                     </execution>
                     <execution>
-                        <id>report</id>
+                        <id>generate-code-coverage-report</id>
                         <phase>test</phase>
                         <goals>
                             <goal>report</goal>
@@ -421,6 +423,7 @@
                 <configuration>
                     <propertyName>SDK</propertyName>
                     <propertyName>version</propertyName>
+                    <propertyName>surefireArgLine</propertyName>
                 </configuration>
             </plugin>
         </plugins>