From 0b08116bb8d46ef9f45dabf2c28cf96a1d955196 Mon Sep 17 00:00:00 2001 From: saiko Date: Sat, 30 Sep 2017 23:50:41 +0530 Subject: [PATCH 1/5] Fix test and add new env variable property --- env/default.properties | 3 ++- pom.xml | 6 +++--- .../com/sitture/maven/properties/PropertiesTest.java | 12 +++++++++++- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/env/default.properties b/env/default.properties index 4afd123..fe651e7 100644 --- a/env/default.properties +++ b/env/default.properties @@ -1 +1,2 @@ -property.package=propertyValue \ No newline at end of file +property.package=propertyValue +property.version=${project.version} \ No newline at end of file diff --git a/pom.xml b/pom.xml index 2a4d69b..71794d0 100644 --- a/pom.xml +++ b/pom.xml @@ -48,11 +48,10 @@ 1.0.0 + read-properties initialize - - read-project-properties - + read-project-properties @@ -69,6 +68,7 @@ ${property.package} + ${property.version} diff --git a/src/test/java/com/sitture/maven/properties/PropertiesTest.java b/src/test/java/com/sitture/maven/properties/PropertiesTest.java index c57ab1d..29a58e0 100644 --- a/src/test/java/com/sitture/maven/properties/PropertiesTest.java +++ b/src/test/java/com/sitture/maven/properties/PropertiesTest.java @@ -2,11 +2,21 @@ import org.junit.Test; +import org.junit.Assert; + public class PropertiesTest { @Test public void canGetProperty() { - System.out.println(System.getProperty("property.package")); + String prop1 = System.getProperty("my.Property"); + String prop2 = System.getProperty("her.Property"); + + System.out.println(prop1); + + System.out.println(prop2); + + Assert.assertNotNull(prop1); + Assert.assertNotNull(prop2); } } From 2b56596ee3293c8af7386416e501ab7a36e635a3 Mon Sep 17 00:00:00 2001 From: saiko Date: Sat, 30 Sep 2017 23:54:39 +0530 Subject: [PATCH 2/5] Remove blank line --- src/test/java/com/sitture/maven/properties/PropertiesTest.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/test/java/com/sitture/maven/properties/PropertiesTest.java b/src/test/java/com/sitture/maven/properties/PropertiesTest.java index 29a58e0..132c55e 100644 --- a/src/test/java/com/sitture/maven/properties/PropertiesTest.java +++ b/src/test/java/com/sitture/maven/properties/PropertiesTest.java @@ -11,8 +11,7 @@ public void canGetProperty() { String prop1 = System.getProperty("my.Property"); String prop2 = System.getProperty("her.Property"); - System.out.println(prop1); - + System.out.println(prop1); System.out.println(prop2); Assert.assertNotNull(prop1); From c015e9ab395de97dc9c44226d24874cfa8edab84 Mon Sep 17 00:00:00 2001 From: saiko Date: Sat, 30 Sep 2017 23:58:41 +0530 Subject: [PATCH 3/5] Update readme --- README.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/README.md b/README.md index b46102f..6d5150d 100644 --- a/README.md +++ b/README.md @@ -1,2 +1,10 @@ # maven-properties-example An example project for working with system properties. + +## Pre-requisites +* JDK 1.7 +* Maven 3 +* Internet Connection to download the dependencies + +## How to run +To run the JUnit tests from terminal run `mvn -Pandroid clean test` From 8b119c6bebbb264e2e579b94d2383ffc18c73a09 Mon Sep 17 00:00:00 2001 From: saiko Date: Sun, 1 Oct 2017 11:06:49 +0530 Subject: [PATCH 4/5] Add new example --- env/default.properties | 5 ++++- pom.xml | 1 + .../com/sitture/maven/properties/PropertiesTest.java | 11 ++++++++--- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/env/default.properties b/env/default.properties index fe651e7..8d87090 100644 --- a/env/default.properties +++ b/env/default.properties @@ -1,2 +1,5 @@ property.package=propertyValue -property.version=${project.version} \ No newline at end of file +property.version=${project.version} + +# an environment variable +pathvar=${env.PATH} \ No newline at end of file diff --git a/pom.xml b/pom.xml index 71794d0..de81314 100644 --- a/pom.xml +++ b/pom.xml @@ -69,6 +69,7 @@ ${property.package} ${property.version} + ${pathvar} diff --git a/src/test/java/com/sitture/maven/properties/PropertiesTest.java b/src/test/java/com/sitture/maven/properties/PropertiesTest.java index 132c55e..027c015 100644 --- a/src/test/java/com/sitture/maven/properties/PropertiesTest.java +++ b/src/test/java/com/sitture/maven/properties/PropertiesTest.java @@ -10,12 +10,17 @@ public class PropertiesTest { public void canGetProperty() { String prop1 = System.getProperty("my.Property"); String prop2 = System.getProperty("her.Property"); - - System.out.println(prop1); + String prop3 = System.getProperty("pathvar"); + + // System.out.println("..........." + System.getenv("PATH")); + + System.out.println(prop1); System.out.println(prop2); - + System.out.println(prop3); + Assert.assertNotNull(prop1); Assert.assertNotNull(prop2); + Assert.assertNotNull(prop3); } } From aecc06da585f159c7b6faee7fdfaa800bb2ae17f Mon Sep 17 00:00:00 2001 From: saiko Date: Sun, 1 Oct 2017 11:07:44 +0530 Subject: [PATCH 5/5] Change the name --- pom.xml | 2 +- src/test/java/com/sitture/maven/properties/PropertiesTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index de81314..1c0c3ea 100644 --- a/pom.xml +++ b/pom.xml @@ -69,7 +69,7 @@ ${property.package} ${property.version} - ${pathvar} + ${pathvar} diff --git a/src/test/java/com/sitture/maven/properties/PropertiesTest.java b/src/test/java/com/sitture/maven/properties/PropertiesTest.java index 027c015..f1dd668 100644 --- a/src/test/java/com/sitture/maven/properties/PropertiesTest.java +++ b/src/test/java/com/sitture/maven/properties/PropertiesTest.java @@ -10,7 +10,7 @@ public class PropertiesTest { public void canGetProperty() { String prop1 = System.getProperty("my.Property"); String prop2 = System.getProperty("her.Property"); - String prop3 = System.getProperty("pathvar"); + String prop3 = System.getProperty("my.pathvar"); // System.out.println("..........." + System.getenv("PATH"));