Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add versioning or latest commit information to our about page #917

Open
1 of 2 tasks
NoamGaash opened this issue Nov 14, 2024 · 10 comments
Open
1 of 2 tasks

add versioning or latest commit information to our about page #917

NoamGaash opened this issue Nov 14, 2024 · 10 comments
Assignees
Labels
ci improvements to our CI pipeline good first issue Good for newcomers

Comments

@NoamGaash
Copy link
Member

NoamGaash commented Nov 14, 2024

It seems like we have some problems with our deployments, or with the caching mechanism, and the frontend isn't always up-to-date on production.
It would help to have some endpoint / entry in the about page that will show the current version

Suggested steps (can be done in same PR or seperated PRs):

  • add the commit hash to environment variable or a file in the docker image
  • expose this variable
@NoamGaash NoamGaash added good first issue Good for newcomers ci improvements to our CI pipeline labels Nov 14, 2024
@TomRytt TomRytt self-assigned this Nov 19, 2024
@TomRytt TomRytt removed their assignment Dec 9, 2024
@ofirc77
Copy link
Collaborator

ofirc77 commented Dec 19, 2024

Hi @NoamGaash,
Can you please share the flow that we want to have in general for this task and maybe a good place to start with?

@NoamGaash
Copy link
Member Author

@ofirc77 sure, thanks!
I think a good starting point would be the build workflow - https://github.com/hasadna/open-bus-map-search/blob/main/.github/workflows/build.yml

Writing the commit sha to a file called version-info.json in the public folder could be a nice starting point :)

@ofirc77
Copy link
Collaborator

ofirc77 commented Feb 10, 2025

Can we close this issue?

@NoamGaash
Copy link
Member Author

I see that we merged #1010 but https://open-bus-map-search.hasadna.org.il/hash.txt still doesn't serve the hash

@NoamGaash
Copy link
Member Author

I assume that https://github.com/hasadna/open-bus-map-search/blob/main/.github/workflows/cd.yml should be updated as well

@ofirc77
Copy link
Collaborator

ofirc77 commented Feb 13, 2025

Added a pull request - #1034

@ofirc77
Copy link
Collaborator

ofirc77 commented Feb 15, 2025

After commit was pushed, it seems that issue was resolved :)

@NoamGaash
Copy link
Member Author

amazing, thanks! 🥳 🎊 🚀

@NoamGaash NoamGaash reopened this Feb 15, 2025
@NoamGaash
Copy link
Member Author

next step - add a component to the about page that checks the hash URL and displays it as the current build version

@NoamGaash
Copy link
Member Author

NoamGaash commented Feb 15, 2025

opened #1037 that could solve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvements to our CI pipeline good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants