Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect when resources are added that aren't covered by existing service labels #21287

Open
melinath opened this issue Feb 6, 2025 · 0 comments

Comments

@melinath
Copy link
Collaborator

melinath commented Feb 6, 2025

What kind of contribution is this issue about?

Other (specify in details)

Details

This should help avoid adding resources that aren't covered in https://github.com/GoogleCloudPlatform/magic-modules/blob/main/tools/issue-labeler/labeler/enrolled_teams.yml.

References

No response

melinath added a commit to melinath/magic-modules that referenced this issue Feb 6, 2025
This is a prerequisite to hashicorp/terraform-provider-google#21287 because it will allow distinguishing between added, modified, and removed resources.

I also made the computation of the primary schema diff happen at build time, since it is a static value.
@melinath melinath self-assigned this Feb 7, 2025
melinath added a commit to melinath/magic-modules that referenced this issue Feb 7, 2025
This is a prerequisite to hashicorp/terraform-provider-google#21287 because it will allow distinguishing between added, modified, and removed resources.

I also made the computation of the primary schema diff happen at build time, since it is a static value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant