You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1. try to make small patches - the bigger they are, the longer the pull request QA process will take
72
72
2. strictly separate all changes that affect functionality from those that just affect code layout, indentation, whitespace, filenames etc
73
-
3. always include the issue number (of the form `fixes #N`) in the final commit message for the patch - pull requests without an issue are unlikely to have been discussed (see above)
73
+
3. always include the issue number (of the form `PROJECT_CODE #resolve Fixed`) in the final commit message for the patch - pull requests without an issue are unlikely to have been discussed (see above)
74
74
4. use Unix conventions for line endings. If you are on Windows, ensure that git handles line-endings sanely by running `git config --global core.autocrlf false`
75
-
5. make sure you have setup git to use the correct name and email for your commits - see the [github help guide](https://help.github.com/articles/setting-your-email-in-git)
75
+
5. make sure you have setup git to use the correct name and email for your commits - see the [github help guide](https://help.github.com/articles/setting-your-email-in-git) - otherwise you won't be attributed in the scm history!
76
76
77
77
### __4. Make sure all the tests pass__
78
78
@@ -171,7 +171,7 @@ import Data.Blah
171
171
import Data.Boom (Typeable)
172
172
{% endhighlight %}
173
173
174
-
Personally I don't care *that much* about alignment for other things,
174
+
We generally don't care *that much* about alignment for other things,
175
175
but as always, try to follow the convention in the file you're editing
176
176
and don't change things just for the sake of it.
177
177
@@ -186,18 +186,18 @@ punctuation.
186
186
187
187
Comment every top level function (particularly exported functions),
188
188
and provide a type signature; use Haddock syntax in the comments.
189
-
Comment every exported data type. Function example:
189
+
Comment every exported data type. Function example:
190
190
191
191
{% highlight haskell %}
192
-
-- | Send a message on a socket. The socket must be in a connected
193
-
-- state. Returns the number of bytes sent. Applications are
192
+
-- | Send a message on a socket. The socket must be in a connected
193
+
-- state. Returns the number of bytes sent. Applications are
194
194
-- responsible for ensuring that all data has been sent.
195
195
send :: Socket -- ^ Connected socket
196
196
-> ByteString -- ^ Data to send
197
197
-> IO Int -- ^ Bytes sent
198
198
{% endhighlight %}
199
199
200
-
For functions the documentation should give enough information to
200
+
For functions, the documentation should give enough information to
201
201
apply the function without looking at the function's definition.
202
202
203
203
### Naming
@@ -214,3 +214,4 @@ abbreviation. For example, write `HttpServer` instead of
214
214
Use singular when naming modules e.g. use `Data.Map` and
215
215
`Data.ByteString.Internal` instead of `Data.Maps` and
0 commit comments