Skip to content

Commit 8920df8

Browse files
committed
wiki changes
1 parent bc67edf commit 8920df8

File tree

3 files changed

+16
-25
lines changed

3 files changed

+16
-25
lines changed

wiki/contributing.md

+13-12
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,10 @@ We have a rather full backlog, so your help will be most welcome assisting
2424
us in clearing that. You can view the exiting open issues on the
2525
[jira issue tracker](https://cloud-haskell.atlassian.net/issues/?filter=10001).
2626

27-
If you wish to submit an issue there, you can do so without logging in,
28-
although you obviously won't get any email notifications unless you create
29-
an account and provide your email address.
27+
If you wish to submit a new issue there, you cannot do so without logging in
28+
creating an account (by providing your email address) and logging in.
3029

31-
It is also important to work out which component or sub-system should be
30+
It is also helpful to work out which component or sub-system should be
3231
changed. You may wish to email the maintainers to discuss this first.
3332

3433
### __2. Make sure your patch merges cleanly__
@@ -47,7 +46,8 @@ local branch. For example:
4746

4847
$ git checkout -b bugfix-issue123
4948

50-
## make, add and commit your changes
49+
## add and commit your changes
50+
## base them on master for bugfixes or development for new features
5151

5252
$ git checkout master
5353
$ git remote add upstream git://github.com/haskell-distributed/distributed-process.git
@@ -70,9 +70,9 @@ conventions page [here](http://hackage.haskell.org/trac/ghc/wiki/WorkingConventi
7070

7171
1. try to make small patches - the bigger they are, the longer the pull request QA process will take
7272
2. strictly separate all changes that affect functionality from those that just affect code layout, indentation, whitespace, filenames etc
73-
3. always include the issue number (of the form `fixes #N`) in the final commit message for the patch - pull requests without an issue are unlikely to have been discussed (see above)
73+
3. always include the issue number (of the form `PROJECT_CODE #resolve Fixed`) in the final commit message for the patch - pull requests without an issue are unlikely to have been discussed (see above)
7474
4. use Unix conventions for line endings. If you are on Windows, ensure that git handles line-endings sanely by running `git config --global core.autocrlf false`
75-
5. make sure you have setup git to use the correct name and email for your commits - see the [github help guide](https://help.github.com/articles/setting-your-email-in-git)
75+
5. make sure you have setup git to use the correct name and email for your commits - see the [github help guide](https://help.github.com/articles/setting-your-email-in-git) - otherwise you won't be attributed in the scm history!
7676

7777
### __4. Make sure all the tests pass__
7878

@@ -171,7 +171,7 @@ import Data.Blah
171171
import Data.Boom (Typeable)
172172
{% endhighlight %}
173173

174-
Personally I don't care *that much* about alignment for other things,
174+
We generally don't care *that much* about alignment for other things,
175175
but as always, try to follow the convention in the file you're editing
176176
and don't change things just for the sake of it.
177177

@@ -186,18 +186,18 @@ punctuation.
186186

187187
Comment every top level function (particularly exported functions),
188188
and provide a type signature; use Haddock syntax in the comments.
189-
Comment every exported data type. Function example:
189+
Comment every exported data type. Function example:
190190

191191
{% highlight haskell %}
192-
-- | Send a message on a socket. The socket must be in a connected
193-
-- state. Returns the number of bytes sent. Applications are
192+
-- | Send a message on a socket. The socket must be in a connected
193+
-- state. Returns the number of bytes sent. Applications are
194194
-- responsible for ensuring that all data has been sent.
195195
send :: Socket -- ^ Connected socket
196196
-> ByteString -- ^ Data to send
197197
-> IO Int -- ^ Bytes sent
198198
{% endhighlight %}
199199

200-
For functions the documentation should give enough information to
200+
For functions, the documentation should give enough information to
201201
apply the function without looking at the function's definition.
202202

203203
### Naming
@@ -214,3 +214,4 @@ abbreviation. For example, write `HttpServer` instead of
214214
Use singular when naming modules e.g. use `Data.Map` and
215215
`Data.ByteString.Internal` instead of `Data.Maps` and
216216
`Data.ByteString.Internals`.
217+

wiki/maintainers.md

+3-11
Original file line numberDiff line numberDiff line change
@@ -117,17 +117,9 @@ What's good for the goose...
117117

118118
#### Making API documentation available on the website
119119

120-
Currently this is a manual process. If you don't sed/awk out the
121-
reference/link paths, it'll be a mess. We will add a script to
122-
handle this some time soon. I tend to only update the static
123-
documentation for d-p and d-p-platform, at least until the process has
124-
been automated. I also do this *only* for mainline branches (i.e.,
125-
for development and master), although again, automation could solve
126-
a lot of issues there.
127-
128-
There is also an open ticket to set up nightly builds, which will
129-
update the HEAD haddocks (on the website) and produce an 'sdist'
130-
bundle and add that to the website too.
120+
There is an open ticket to set up nightly builds, which will update
121+
the HEAD haddocks (on the website) and produce an 'sdist' bundle and
122+
add that to the website too.
131123

132124
See https://cloud-haskell.atlassian.net/browse/INFRA-1 for details.
133125

wiki/reliability.md

-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ child processes. A supervisors *children* can be either worker processes or
2828
supervisors, which allows us to build hierarchical process structures (called
2929
supervision trees in Erlang parlance).
3030

31-
The supervision APIs are a work in progress.
32-
3331
[1]: http://en.wikipedia.org/wiki/Open_Telecom_Platform
3432
[2]: http://www.erlang.org/doc/design_principles/sup_princ.html
3533
[3]: http://www.erlang.org/doc/man/supervisor.html

0 commit comments

Comments
 (0)