Skip to content

Commit 4d784cc

Browse files
committed
Default to zero tolerance
1 parent 254868b commit 4d784cc

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

scripts/hpc-ratchet

+3-4
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,8 @@ def compare_values((covered, total), tolerance):
144144

145145
def compare_coverage(report, desired):
146146
comparison = {}
147-
# TODO: Iterate over report and default to 0 for missing keys in desired.
148-
for key, tolerance in desired.items():
149-
actual = report.get(key, None)
147+
for key, actual in report.items():
148+
tolerance = desired.get(key, 0)
150149
if actual:
151150
comparison[key] = compare_values(actual, tolerance)
152151
else:
@@ -181,7 +180,7 @@ def main():
181180
for key, value in sorted(comparison.items()):
182181
if value != 0:
183182
all_same = False
184-
print format_entry(key, value, COVERAGE_TOLERANCE[key], report[key])
183+
print format_entry(key, value, COVERAGE_TOLERANCE.get(key, 0), report[key])
185184
sys.exit(0 if all_same else 2)
186185

187186

0 commit comments

Comments
 (0)