Fix bounds check in cloneM, add CI with -fdebug (#331)

Fixes #330, #329.

Author: sjakobi

.github/workflows/haskell-ci.yml

@@ -1,16 +1,16 @@
 # This GitHub workflow config has been generated by a script via
 #
-#   haskell-ci 'github' '--benchmarks-jobs= < 9.2' '--installed=-containers' '--installed=-binary' 'unordered-containers.cabal' '--branches=master'
+#   haskell-ci 'github' 'unordered-containers.cabal'
 #
 # To regenerate the script (for example after adjusting tested-with) run
 #
 #   haskell-ci regenerate
 #
 # For more information, see https://github.com/haskell-CI/haskell-ci
 #
-# version: 0.13.20211030
+# version: 0.13.20211116
 #
-# REGENDATA ("0.13.20211030",["github","--benchmarks-jobs= < 9.2","--installed=-containers","--installed=-binary","unordered-containers.cabal","--branches=master"])
+# REGENDATA ("0.13.20211116",["github","unordered-containers.cabal"])
 #
 name: Haskell-CI
 on:
@@ -24,6 +24,8 @@ jobs:
   linux:
     name: Haskell-CI - Linux - ${{ matrix.compiler }}
     runs-on: ubuntu-18.04
+    timeout-minutes:
+      60
     container:
       image: buildpack-deps:bionic
     continue-on-error: ${{ matrix.allow-failure }}
@@ -149,6 +151,10 @@ jobs:
           repository hackage.haskell.org
             url: http://hackage.haskell.org/
           EOF
+          cat >> $CABAL_CONFIG <<EOF
+          program-default-options
+            ghc-options: $GHCJOBS +RTS -M3G -RTS
+          EOF
           cat $CABAL_CONFIG
       - name: versions
         run: |
@@ -233,3 +239,11 @@ jobs:
         run: |
           rm -f cabal.project.local
           $CABAL v2-build $ARG_COMPILER --disable-tests --disable-benchmarks all
+      - name: prepare for constraint sets
+        run: |
+          rm -f cabal.project.local
+      - name: constraint set debug
+        run: |
+          $CABAL v2-build $ARG_COMPILER --enable-tests --disable-benchmarks --constraint='unordered-containers +debug' --dependencies-only -j2 all
+          $CABAL v2-build $ARG_COMPILER --enable-tests --disable-benchmarks --constraint='unordered-containers +debug' all
+          $CABAL v2-test $ARG_COMPILER --enable-tests --disable-benchmarks --constraint='unordered-containers +debug' all

Data/HashMap/Internal/Array.hs

@@ -281,7 +281,7 @@ copyM !src !_sidx@(I# sidx#) !dst !_didx@(I# didx#) _n@(I# n#) =
 
 cloneM :: MArray s a -> Int -> Int -> ST s (MArray s a)
 cloneM _mary@(MArray mary#) _off@(I# off#) _len@(I# len#) =
-    CHECK_BOUNDS("cloneM_off", lengthM _mary, _off - 1)
+    CHECK_BOUNDS("cloneM_off", lengthM _mary, _off)
     CHECK_BOUNDS("cloneM_end", lengthM _mary, _off + _len - 1)
     ST $ \ s ->
     case cloneSmallMutableArray# mary# off# len# s of

cabal.haskell-ci

@@ -0,0 +1,14 @@
+-- Configuration for haskell-ci
+
+branches: master
+
+-- Due to https://github.com/haskell-foundation/foundation/issues/554 via gauge.
+benchmarks: <9.2
+
+constraint-set debug
+  constraints: unordered-containers +debug
+  tests:       True
+  run-tests:   True
+
+installed: -containers
+installed: -binary