Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code duplication #64

Open
tibbe opened this issue May 10, 2013 · 0 comments · May be fixed by #188
Open

Reduce code duplication #64

tibbe opened this issue May 10, 2013 · 0 comments · May be fixed by #188
Labels
maintenance

Comments

@tibbe
Copy link
Collaborator

tibbe commented May 10, 2013

There's excessive code duplication in the library due to near-identical implementations of several functions. This duplication has two causes:

  • Optimizations:
    • In the name of efficiency, some functions have been duplicate to avoid the cost of unused generality. For example, we have separate implementation of insert and insertWith, even though the former could be implemented in terms of the latter.
    • To support in-place update in the implementation of e.g. fromList, we have in-place versions of some functions e.g. unsafeInsert.
  • To provide both a strict and a lazy interface, some operations e.g. insertWith, have two implementations which only differs in the use of a seq or two.

I believe we can get rid of this duplication by implementing some generic functions that the others can be implemented in terms of and inline these hard enough.
treeowl added a commit to treeowl/unordered-containers that referenced this issue Feb 8, 2018
@treeowl
Reduce code size with unboxed unary tuples
f731400 
Experimentally make most strict and lazy functions share code
using unboxed unary tuples. I fear we may find this too expensive,
but it's an idea. Needs heavy benchmarking.

Addresses haskell-unordered-containers#64
@treeowl treeowl linked a pull request Feb 8, 2018 that will close this issue
Draft
treeowl added a commit to treeowl/unordered-containers that referenced this issue Feb 8, 2018
@treeowl
Reduce code size with unboxed unary tuples
0046161 
Experimentally make most strict and lazy functions share code
using unboxed unary tuples. I fear we may find this too expensive,
but it's an idea. Needs heavy benchmarking.

Addresses haskell-unordered-containers#64
treeowl added a commit to treeowl/unordered-containers that referenced this issue Feb 8, 2018
@treeowl
Reduce code size with unboxed unary tuples
a8b40cb 
Experimentally make most strict and lazy functions share code
using unboxed unary tuples. I fear we may find this too expensive,
but it's an idea. Needs heavy benchmarking.

Addresses haskell-unordered-containers#64
treeowl added a commit to treeowl/unordered-containers that referenced this issue Feb 8, 2018
@treeowl
Reduce code size with unboxed unary tuples
5b1218a 
Experimentally make most strict and lazy functions share code
using unboxed unary tuples. I fear we may find this too expensive,
but it's an idea. Needs heavy benchmarking.

Addresses haskell-unordered-containers#64
@sjakobi sjakobi linked a pull request May 31, 2020 that will close this issue
Reduce code size with unboxed unary tuples #188
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce code size with unboxed unary tuples treeowl/unordered-containers
2 participants
@tibbe @sjakobi