Remove compiler warnings

There were few functions with some constraints that were
redundant. Those constraints got removed.

Author: Pawel Szulc

hie-plugin-api/Haskell/Ide/Engine/ModuleCache.hs

@@ -164,8 +164,7 @@ loadCradle publishDiagnostics iniDynFlags (NewCradle fp) def action = do
  where
   -- | Initialise the given cradle. This might fail and return an error via `IdeResultFail`.
   -- Reports its progress to the client.
-  initialiseCradle :: (MonadIde m, HasGhcModuleCache m, GHC.GhcMonad m)
-                  => Bios.Cradle -> (Progress -> IO ()) -> m (IdeResult a)
+  initialiseCradle :: Bios.Cradle -> (Progress -> IO ()) -> m (IdeResult a)
   initialiseCradle cradle f = do
     res <- initializeFlagsWithCradleWithMessage (Just (toMessager f)) fp cradle
     case res of
@@ -333,7 +332,7 @@ ifCachedModuleM fp k callback = do
 -- available.
 -- If you are in IdeDeferM and would like to wait until a cached module is available,
 -- see also 'withCachedModuleAndData'.
-ifCachedModuleAndData :: forall a b m. (ModuleCache a, HasGhcModuleCache m, MonadIO m, MonadMTState IdeState m)
+ifCachedModuleAndData :: forall a b m. (ModuleCache a, HasGhcModuleCache m, MonadMTState IdeState m)
                       => FilePath -> b -> (GHC.TypecheckedModule -> CachedInfo -> a -> m b) -> m b
 ifCachedModuleAndData fp def callback = do
   muc <- getUriCache fp
@@ -388,7 +387,7 @@ deferIfNotCached fp cb = do
     Just res -> cb res
     Nothing -> wrap (Defer fp cb)
 
-lookupCachedData :: forall a m. (HasGhcModuleCache m, MonadMTState IdeState m, MonadIO m, Typeable a, ModuleCache a)
+lookupCachedData :: forall a m. (HasGhcModuleCache m, MonadMTState IdeState m, ModuleCache a)
                  => FilePath -> GHC.TypecheckedModule -> CachedInfo -> (Map.Map TypeRep Dynamic) -> m a
 lookupCachedData fp tm info dat = do
   canonical_fp <- liftIO $ canonicalizePath fp
@@ -520,7 +519,7 @@ deleteCachedModule uri = do
 -- TODO: this name is confusing, given GhcModuleCache. Change it
 class Typeable a => ModuleCache a where
     -- | Defines an initial value for the state extension
-    cacheDataProducer :: (MonadIO m, MonadMTState IdeState m)
+    cacheDataProducer :: (MonadMTState IdeState m)
                       => GHC.TypecheckedModule -> CachedInfo -> m a
 
 instance ModuleCache () where

hie-plugin-api/Haskell/Ide/Engine/PluginUtils.hs

@@ -293,10 +293,8 @@ getRangeFromVFS uri rg = do
 
 data ErrorHandler m a = forall e . Exception e => ErrorHandler (e -> m a)
 
-gcatches :: forall m a . (MonadIO m, ExceptionMonad m) => m a -> [ErrorHandler m a] -> m a
+gcatches :: forall m a . (ExceptionMonad m) => m a -> [ErrorHandler m a] -> m a
 gcatches act handlers = gcatch act h
   where
     h :: SomeException -> m a
     h e = foldr (\(ErrorHandler hand) me -> maybe me hand (fromException e)) (liftIO $ throw e) handlers
-
-

hie-plugin-api/Haskell/Ide/Engine/PluginsIdeMonads.hs

@@ -440,7 +440,7 @@ getPlugins = idePlugins <$> getIdeEnv
 -- | 'withProgress' @title cancellable f@ wraps a progress reporting session for long running tasks.
 -- f is passed a reporting function that can be used to give updates on the progress
 -- of the task.
-withProgress :: (MonadIde m , MonadIO m, MonadBaseControl IO m)
+withProgress :: (MonadIde m , MonadBaseControl IO m)
              => T.Text -> Core.ProgressCancellable
              -> ((Core.Progress -> IO ()) -> m a) -> m a
 withProgress t c f = do

hie-plugin-api/Haskell/Ide/Engine/TypeMap.hs

@@ -56,21 +56,21 @@ processBind _ = return IM.empty
 types :: forall m a . (GhcMonad m, Data a) => a -> m TypeMap
 types = everythingButTypeM @GHC.Id (ty `combineM` fun `combineM` funBind)
  where
-  ty :: forall a' . (GhcMonad m, Data a') => a' -> m TypeMap
+  ty :: forall a' . (Data a') => a' -> m TypeMap
   ty term = case cast term of
     (Just lhsExprGhc@(GHC.L (GHC.RealSrcSpan spn) _)) ->
       getType lhsExprGhc >>= \case
         Nothing       -> return IM.empty
         Just (_, typ) -> return (IM.singleton (rspToInt spn) typ)
     _ -> return IM.empty
 
-  fun :: forall a' . (GhcMonad m, Data a') => a' -> m TypeMap
+  fun :: forall a' . (Data a') => a' -> m TypeMap
   fun term = case cast term of
     (Just (GHC.L (GHC.RealSrcSpan spn) hsPatType)) ->
       return (IM.singleton (rspToInt spn) (TcHsSyn.hsPatType hsPatType))
     _ -> return IM.empty
 
-  funBind :: forall a' . (GhcMonad m, Data a') => a' -> m TypeMap
+  funBind :: forall a' . (Data a') => a' -> m TypeMap
   funBind term = case cast term of
     (Just (GHC.L (GHC.RealSrcSpan spn) (Compat.FunBindType t))) ->
       return (IM.singleton (rspToInt spn) t)