Skip to content

request for floskell 11 support in hls-floskell-plugin #3927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peterbecich opened this issue Jan 5, 2024 · 2 comments · Fixed by #3933
Closed

request for floskell 11 support in hls-floskell-plugin #3927

peterbecich opened this issue Jan 5, 2024 · 2 comments · Fixed by #3933
Labels
component: formatters level: easy The issue is suited for beginners type: enhancement New feature or request

Comments

@peterbecich
Copy link
Member

Is your enhancement request related to a problem? Please describe.

floskell < 11 does not support aeson 2.2
floskell 11 supports aeson 2.2.
https://hackage.haskell.org/package/floskell-0.11.1

The latest version of hls-floskell-plugin supports floskell < 11.
https://hackage.haskell.org/package/hls-floskell-plugin-2.5.0.0

This makes hls-floskell-plugin difficult to build with Nix when using aeson 2.2.

Describe the solution you'd like

Support for floskell 11 would make it easier to build hls-floskell-plugin with Nix and aeson 2.2.

Describe alternatives you've considered

Additional context

The latest version of floskell in NixPkgs is floskell 0.11.0: https://github.com/NixOS/nixpkgs/blob/42ad9df28c071f8865f3167b1c875b6abead7c2b/pkgs/development/haskell-modules/hackage-packages.nix#L107834

Thanks

@michaelpj michaelpj added the level: easy The issue is suited for beginners label Jan 5, 2024
@michaelpj
Copy link
Collaborator

Note that nobody active is currently maintaining the floskell plugin. If you use it, maybe you would like to maintain it?

@peterbecich
Copy link
Member Author

I'd be happy to keep an eye on the plugin. Here is a fix for this issue #3933 with some questionable changes to package version numbers, feedback appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: formatters level: easy The issue is suited for beginners type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants