revert from connectionName to connection_name. Turns out ndc uses snake_case, not camelCase, so best be consistent.

Author: BenoitRanque

crates/configuration/src/version5/connection_settings.rs

@@ -45,7 +45,7 @@ impl DatabaseConnectionSettings {
 pub enum DynamicConnectionSettings {
     Named {
         connection_uris: ConnectionUris,
-        /// When set to true, fallback to using the connectionUri if the connectionName request argument is missing
+        /// When set to true, fallback to using the connectionUri if the connection_name request argument is missing
         /// If this is not set, the connectionUri is not used at runtime, but will still be used by cli utilities
         #[serde(default)]
         fallback_to_static: bool,
@@ -55,6 +55,9 @@ pub enum DynamicConnectionSettings {
         eager_connections: bool,
     },
     Dynamic {
+        /// When set to true, fallback to using the connectionUri if the connection_string request argument is missing
+        /// If this is not set, the connectionUri is not used at runtime, but will still be used by cli utilities
+        #[serde(default)]
         fallback_to_static: bool,
     },
 }

crates/connectors/ndc-postgres/src/state.rs

@@ -23,8 +23,8 @@ use ndc_postgres_configuration::PoolSettings;
 use query_engine_execution::database_info::{self, DatabaseInfo, DatabaseVersion};
 use query_engine_execution::metrics;
 
-const CONNECTION_NAME_ARGUMENT: &str = "connectionName";
-const CONNECTION_STRING_ARGUMENT: &str = "connectionString";
+const CONNECTION_NAME_ARGUMENT: &str = "connection_name";
+const CONNECTION_STRING_ARGUMENT: &str = "connection_string";
 
 /// State for our connector.
 #[derive(Debug)]