From 63b4a7f887001a6187432425b03d959f8887741c Mon Sep 17 00:00:00 2001 From: Hector Borras Date: Tue, 20 Aug 2019 18:44:22 +0200 Subject: [PATCH 1/5] Changed API VERSION --- src/TwitterAds.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/TwitterAds.php b/src/TwitterAds.php index 48883a9..1aaba46 100644 --- a/src/TwitterAds.php +++ b/src/TwitterAds.php @@ -21,7 +21,7 @@ */ class TwitterAds extends Config { - const API_VERSION = '4'; + const API_VERSION = '5'; const API_REST_VERSION = '1.1'; const API_HOST = 'https://ads-api.twitter.com'; const API_HOST_SANDBOX = 'https://ads-api-sandbox.twitter.com'; From 1f104d4d547b61e9d115023d4d6c7a57eb247ef7 Mon Sep 17 00:00:00 2001 From: Hector Borras Date: Tue, 20 Aug 2019 18:48:01 +0200 Subject: [PATCH 2/5] Added with draft parameter --- src/TwitterAds/Fields/CampaignFields.php | 1 + src/TwitterAds/Fields/LineItemFields.php | 11 ++++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/TwitterAds/Fields/CampaignFields.php b/src/TwitterAds/Fields/CampaignFields.php index 5d947d9..8544256 100644 --- a/src/TwitterAds/Fields/CampaignFields.php +++ b/src/TwitterAds/Fields/CampaignFields.php @@ -25,6 +25,7 @@ class CampaignFields extends Fields const SORT_BY = 'sort_by'; const ENTITY_STATUS = 'entity_status'; const WITH_TOTAL_COUNT = 'with_total_count'; + const WITH_DRAFT = 'with_draft'; const ACCOUNT_ID = 'account_id'; const CAMPAIGN_IDS = 'campaign_ids'; diff --git a/src/TwitterAds/Fields/LineItemFields.php b/src/TwitterAds/Fields/LineItemFields.php index 47f8ffd..932f5c7 100644 --- a/src/TwitterAds/Fields/LineItemFields.php +++ b/src/TwitterAds/Fields/LineItemFields.php @@ -31,11 +31,12 @@ class LineItemFields const SORT_BY = 'sort_by'; const ENTITY_STATUS = 'entity_status'; const WITH_TOTAL_COUNT = 'with_total_count'; - const TARGET_CPA_LOCAL_MICRO = 'target_cpa_local_micro'; - const CATEGORIES = 'categories'; - const CURRENCY = 'currency'; - const TRACKING_TAGS = 'tracking_tags'; - const LOOKALIKE_EXPANSION = 'lookalike_expansion'; + const TARGET_CPA_LOCAL_MICRO = 'target_cpa_local_micro'; + const CATEGORIES = 'categories'; + const CURRENCY = 'currency'; + const TRACKING_TAGS = 'tracking_tags'; + const LOOKALIKE_EXPANSION = 'lookalike_expansion'; + const WITH_DRAFT = 'with_draft'; const CAMPAIGN_IDS = 'campaign_ids'; const FUNDING_INSTRUMENT_IDS = 'funding_instrument_ids'; From 3b4e9eb7bcadb6a9525b8ff0ca490c876a9a897b Mon Sep 17 00:00:00 2001 From: Hector Borras Date: Tue, 20 Aug 2019 18:50:58 +0200 Subject: [PATCH 3/5] Removed preview_url parameter --- src/TwitterAds/Creative/ImageAppDownloadCard.php | 9 --------- src/TwitterAds/Creative/ImageConversationCard.php | 9 --------- src/TwitterAds/Creative/VideoAppDownloadCard.php | 9 --------- src/TwitterAds/Creative/VideoConversationCard.php | 9 --------- src/TwitterAds/Fields/ImageAppDownloadCardFields.php | 1 - src/TwitterAds/Fields/ImageConversationCardFields.php | 1 - src/TwitterAds/Fields/VideoAppDownloadCardFields.php | 3 +-- src/TwitterAds/Fields/VideoConversationCardFields.php | 1 - src/TwitterAds/Fields/VideoFields.php | 1 - src/TwitterAds/Fields/WebsiteCardFields.php | 1 - 10 files changed, 1 insertion(+), 43 deletions(-) diff --git a/src/TwitterAds/Creative/ImageAppDownloadCard.php b/src/TwitterAds/Creative/ImageAppDownloadCard.php index 9ad8595..13e6ed5 100644 --- a/src/TwitterAds/Creative/ImageAppDownloadCard.php +++ b/src/TwitterAds/Creative/ImageAppDownloadCard.php @@ -12,7 +12,6 @@ class ImageAppDownloadCard extends Resource /** Read Only */ protected $id; - protected $preview_url; protected $created_at; protected $updated_at; protected $deleted; @@ -50,14 +49,6 @@ public function getId() return $this->id; } - /** - * @return mixed - */ - public function getPreviewUrl() - { - return $this->preview_url; - } - /** * @return mixed */ diff --git a/src/TwitterAds/Creative/ImageConversationCard.php b/src/TwitterAds/Creative/ImageConversationCard.php index d704be4..e8ab57c 100644 --- a/src/TwitterAds/Creative/ImageConversationCard.php +++ b/src/TwitterAds/Creative/ImageConversationCard.php @@ -12,7 +12,6 @@ class ImageConversationCard extends Resource /** Read Only */ protected $id; - protected $preview_url; protected $created_at; protected $updated_at; protected $deleted; @@ -48,14 +47,6 @@ public function getId() return $this->id; } - /** - * @return mixed - */ - public function getPreviewUrl() - { - return $this->preview_url; - } - /** * @return mixed */ diff --git a/src/TwitterAds/Creative/VideoAppDownloadCard.php b/src/TwitterAds/Creative/VideoAppDownloadCard.php index 13a2e00..0a4c1f3 100644 --- a/src/TwitterAds/Creative/VideoAppDownloadCard.php +++ b/src/TwitterAds/Creative/VideoAppDownloadCard.php @@ -12,7 +12,6 @@ class VideoAppDownloadCard extends Resource /** Read Only */ protected $id; - protected $preview_url; protected $video_url; protected $video_poster_url; protected $created_at; @@ -54,14 +53,6 @@ public function getId() return $this->id; } - /** - * @return mixed - */ - public function getPreviewUrl() - { - return $this->preview_url; - } - /** * @return mixed */ diff --git a/src/TwitterAds/Creative/VideoConversationCard.php b/src/TwitterAds/Creative/VideoConversationCard.php index e64a1e4..ce5631a 100644 --- a/src/TwitterAds/Creative/VideoConversationCard.php +++ b/src/TwitterAds/Creative/VideoConversationCard.php @@ -12,7 +12,6 @@ class VideoConversationCard extends Resource /** Read Only */ protected $id; - protected $preview_url; protected $video_url; protected $video_poster_url; protected $created_at; @@ -52,14 +51,6 @@ public function getId() return $this->id; } - /** - * @return mixed - */ - public function getPreviewUrl() - { - return $this->preview_url; - } - /** * @return mixed */ diff --git a/src/TwitterAds/Fields/ImageAppDownloadCardFields.php b/src/TwitterAds/Fields/ImageAppDownloadCardFields.php index 2298e69..c028cd8 100644 --- a/src/TwitterAds/Fields/ImageAppDownloadCardFields.php +++ b/src/TwitterAds/Fields/ImageAppDownloadCardFields.php @@ -8,7 +8,6 @@ class ImageAppDownloadCardFields const CREATED_AT = 'created_at'; const UPDATED_AT = 'updated_at'; const DELETED = 'delete'; - const PREVIEW_URL = 'preview_url'; const NAME = 'name'; const COUNTRY_CODE = 'country_code'; const IPHONE_APP_ID = 'iphone_app_id'; diff --git a/src/TwitterAds/Fields/ImageConversationCardFields.php b/src/TwitterAds/Fields/ImageConversationCardFields.php index 674a6aa..5eb8ff9 100644 --- a/src/TwitterAds/Fields/ImageConversationCardFields.php +++ b/src/TwitterAds/Fields/ImageConversationCardFields.php @@ -8,7 +8,6 @@ class ImageConversationCardFields const CREATED_AT = 'created_at'; const UPDATED_AT = 'updated_at'; const DELETED = 'delete'; - const PREVIEW_URL = 'preview_url'; const NAME = 'name'; const TITLE = 'title'; const FIRST_CTA = 'first_cta'; diff --git a/src/TwitterAds/Fields/VideoAppDownloadCardFields.php b/src/TwitterAds/Fields/VideoAppDownloadCardFields.php index 03bb235..379a370 100644 --- a/src/TwitterAds/Fields/VideoAppDownloadCardFields.php +++ b/src/TwitterAds/Fields/VideoAppDownloadCardFields.php @@ -8,11 +8,10 @@ class VideoAppDownloadCardFields const CREATED_AT = 'created_at'; const UPDATED_AT = 'updated_at'; const DELETED = 'delete'; - const PREVIEW_URL = 'preview_url'; const VIDEO_URL = 'video_url'; const VIDEO_POSTER_URL = 'video_poster_url'; const NAME = 'name'; - const COUNTRY_CODE = 'country_code'; + const COUNTRY_CODE = 'country_code'; const IPHONE_APP_ID = 'iphone_app_id'; const IPHONE_DEEP_LINK = 'iphone_deep_link'; const IPAD_APP_ID = 'ipad_app_id'; diff --git a/src/TwitterAds/Fields/VideoConversationCardFields.php b/src/TwitterAds/Fields/VideoConversationCardFields.php index e129907..da8bdbd 100644 --- a/src/TwitterAds/Fields/VideoConversationCardFields.php +++ b/src/TwitterAds/Fields/VideoConversationCardFields.php @@ -10,7 +10,6 @@ class VideoConversationCardFields const DELETED = 'delete'; const VIDEO_URL = 'video_url'; const VIDEO_POSTER_URL = 'video_poster_url'; - const PREVIEW_URL = 'preview_url'; const NAME = 'name'; const TITLE = 'title'; const FIRST_CTA = 'first_cta'; diff --git a/src/TwitterAds/Fields/VideoFields.php b/src/TwitterAds/Fields/VideoFields.php index 36ce7d9..43e093b 100644 --- a/src/TwitterAds/Fields/VideoFields.php +++ b/src/TwitterAds/Fields/VideoFields.php @@ -12,7 +12,6 @@ class VideoFields const READY_TO_TWEET = 'ready_to_tweet'; const DURATION = 'duration'; const REASONS_NOT_SERVABLE = 'reasons_not_servable'; - const PREVIEW_URL = 'preview_url'; const TITLE = 'title'; const DESCRIPTION = 'description'; const VIDEO_MEDIA_ID = 'video_media_id'; diff --git a/src/TwitterAds/Fields/WebsiteCardFields.php b/src/TwitterAds/Fields/WebsiteCardFields.php index 179584a..a62c43c 100644 --- a/src/TwitterAds/Fields/WebsiteCardFields.php +++ b/src/TwitterAds/Fields/WebsiteCardFields.php @@ -9,7 +9,6 @@ class WebsiteCardFields const CREATED_AT = 'created_at'; const UPDATED_AT = 'updated_at'; const DELETED = 'deleted'; - const PREVIEW_URL = 'preview_url'; const WEBSITE_TITLE = 'website_title'; const WEBSITE_URL = 'website_url'; const IMAGE_MEDIA_ID = 'image_media_id'; From 237cb8c4d8845cfef6e7a5b8bbb7b4c634860fe3 Mon Sep 17 00:00:00 2001 From: Hector Borras Date: Tue, 20 Aug 2019 18:58:52 +0200 Subject: [PATCH 4/5] Changed line_item_id parameter --- src/TwitterAds/Campaign/TargetingCriteria.php | 2 +- src/TwitterAds/Fields/TargetingCriteriaFields.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/TwitterAds/Campaign/TargetingCriteria.php b/src/TwitterAds/Campaign/TargetingCriteria.php index 76bee3a..08aead1 100644 --- a/src/TwitterAds/Campaign/TargetingCriteria.php +++ b/src/TwitterAds/Campaign/TargetingCriteria.php @@ -42,7 +42,7 @@ class TargetingCriteria extends Resource */ public function line_item_all($line_item_id, $params = []) { - $params[TargetingCriteriaFields::LINE_ITEM_ID] = $line_item_id; + $params[TargetingCriteriaFields::LINE_ITEM_IDS] = [$line_item_id]; $resource = str_replace(static::RESOURCE_REPLACE, $this->getTwitterAds()->getAccountId(), static::RESOURCE_COLLECTION); $request = $this->getTwitterAds()->get($resource, $params); diff --git a/src/TwitterAds/Fields/TargetingCriteriaFields.php b/src/TwitterAds/Fields/TargetingCriteriaFields.php index 0d4f745..1d946b8 100644 --- a/src/TwitterAds/Fields/TargetingCriteriaFields.php +++ b/src/TwitterAds/Fields/TargetingCriteriaFields.php @@ -10,7 +10,7 @@ class TargetingCriteriaFields const CREATED_AT = 'created_at'; const UPDATED_AT = 'updated_at'; const DELETED = 'delete'; - const LINE_ITEM_ID = 'line_item_id'; + const LINE_ITEM_IDS = 'line_item_ids'; const TARGETING_TYPE = 'targeting_type'; const TARGETING_VALUE = 'targeting_value'; const TAILORED_AUDIENCE_EXPANSION = 'tailored_audience_expansion'; From 41fa4dbc9b52611f61647facc566ca2b7fb0e8d5 Mon Sep 17 00:00:00 2001 From: Hector Borras Date: Tue, 20 Aug 2019 19:08:43 +0200 Subject: [PATCH 5/5] Fixed lineItemid field --- src/TwitterAds/Fields/TargetingCriteriaFields.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/TwitterAds/Fields/TargetingCriteriaFields.php b/src/TwitterAds/Fields/TargetingCriteriaFields.php index 1d946b8..7e839ce 100644 --- a/src/TwitterAds/Fields/TargetingCriteriaFields.php +++ b/src/TwitterAds/Fields/TargetingCriteriaFields.php @@ -10,7 +10,8 @@ class TargetingCriteriaFields const CREATED_AT = 'created_at'; const UPDATED_AT = 'updated_at'; const DELETED = 'delete'; - const LINE_ITEM_IDS = 'line_item_ids'; + const LINE_ITEM_ID = 'line_item_id'; + const LINE_ITEM_IDS = 'line_item_ids'; const TARGETING_TYPE = 'targeting_type'; const TARGETING_VALUE = 'targeting_value'; const TAILORED_AUDIENCE_EXPANSION = 'tailored_audience_expansion';