Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header text indistinguishable from background video when first displayed #518

Closed
pleasantone opened this issue Feb 27, 2024 · 6 comments · Fixed by #519
Closed

header text indistinguishable from background video when first displayed #518

pleasantone opened this issue Feb 27, 2024 · 6 comments · Fixed by #519
Labels
enhancement New feature or request

Comments

@pleasantone
Copy link

pleasantone commented Feb 27, 2024

Not sure if this is the same issue as #255 , but if you look at <gtj.netlify.app> when the header is first put up, the header background is transparent, and the text may get lost because it doesn't show up against the video background (see active page Home in header).

As soon as you start to scroll, the header background changes to the theme color background. Seems like this behavior was intentional, but then we might consider doing some vignetting around the header text?

@razonyang
Copy link
Member

razonyang commented Feb 28, 2024

There is a color parameter on banner, which may not be documented yet.

---
header:
  banner:
    color: '#DD7815'
---

Actually, I cannot see the difference with the naked eye, even using slow 3G network (Chrome) for testing, do you have a better tool/way to see how it render obviously?

@pleasantone
Copy link
Author

pleasantone commented Feb 28, 2024 via email

@razonyang
Copy link
Member

razonyang commented Feb 28, 2024

Can we make it follow the dark/light theme color?

I didn't get it, could you please provide a reproduce steps/screenshot to describe the issue in detail? Such as theme color, how to make this issue to be rendered more obviously.

The image below was captured from Chrome with slow 3g network, but I didn't see a problem.

image

@pleasantone
Copy link
Author

pleasantone commented Feb 28, 2024

The color parameter affects the text of the banner, and the header, until you scroll... different thing.
I'm talking about the background color of the header -- making it transparent, as it is now, is problematic for distinguishing text if the contrast between the text and the background image isn't high enough...

Current: "Home" (or "Blog") are obscured by lack of contrast:
Screenshot 2024-02-28 at 10 34 54 AM

Proposed: dark theme
Screenshot 2024-02-28 at 10 35 21 AM

Proposed: light theme
Screenshot 2024-02-28 at 10 35 09 AM

The proposed is exactly what you get once you begin to scroll down the page... I'm just advocating for the option to do that without the need to start scrolling.

@pleasantone
Copy link
Author

FWIW, this is a non-issue if one changes to header/theme/pills, so low priority, but still a noted issue.

@razonyang
Copy link
Member

razonyang commented Feb 28, 2024

I see, you mean always show the original background for header menus, it's not related to CLS, and it was by designed, which the video and image is the main concern on page wihtout scrolling (menus share the same background with image and video).

Anyway it make sense to add a parameter to use the original background all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants