Skip to content

Documentation tab in editor dialog breaks on default value #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
skoeva opened this issue Feb 5, 2025 · 0 comments · Fixed by #2856
Closed

Documentation tab in editor dialog breaks on default value #2854

skoeva opened this issue Feb 5, 2025 · 0 comments · Fixed by #2856
Assignees
@skoeva
Labels
frontend Issues related to the frontend kind/bug Categorizes issue or PR as related to a bug.

Comments

@skoeva
Copy link
Contributor

skoeva commented Feb 5, 2025 •
edited
Loading

Describe the bug

When opening the editor with the default text

Image

navigating to the documentation tab causes the app to crash.

Are you able to fix this issue?

[Yes (I will propose a PR) / No.]
Yes

Additional Context

This may be a regression from #1996
Not a regression, just how the logic in the component typically works
@skoeva skoeva added kind/bug Categorizes issue or PR as related to a bug. frontend Issues related to the frontend labels Feb 5, 2025
@skoeva skoeva self-assigned this Feb 5, 2025
skoeva added a commit that referenced this issue Feb 5, 2025
@skoeva
frontend: EditorDialog: Handle incomplete input in docs tab
26e7a37 
This change gracefully handles incomplete or comment-only input from the
editor dialog in the documentation, preventing the app from crashing.

Fixes: #2854

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Feb 5, 2025
@skoeva
frontend: EditorDialog: Handle incomplete input in docs tab
917c91a 
This change gracefully handles incomplete or comment-only input from the
editor dialog in the documentation tab, preventing the app from crashing.

Fixes: #2854

Signed-off-by: Evangelos Skopelitis <[email protected]>
@skoeva skoeva linked a pull request Feb 5, 2025 that will close this issue
frontend: EditorDialog: Handle null YAML in docs tab #2856
Merged
3 tasks
@skoeva skoeva mentioned this issue Feb 5, 2025
Merged
3 tasks
skoeva added a commit that referenced this issue Feb 5, 2025
@skoeva
frontend: EditorDialog: Handle incomplete input in docs tab
fd6a325 
This change gracefully handles incomplete or comment-only input from the
editor dialog in the documentation tab, preventing the app from crashing.

Fixes: #2854

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Feb 5, 2025
@skoeva
frontend: EditorDialog: Handle incomplete input in docs tab
62b8bcd 
This change gracefully handles incomplete or comment-only input from the
editor dialog in the documentation tab, preventing the app from crashing.

Fixes: #2854

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Feb 5, 2025
@skoeva
frontend: EditorDialog: Handle incomplete input in docs tab
e822d14 
This change gracefully handles incomplete or comment-only input from the
editor dialog in the documentation tab, preventing the app from crashing.

Fixes: #2854

Signed-off-by: Evangelos Skopelitis <[email protected]>
@skoeva skoeva marked this as a duplicate of #2855 Feb 10, 2025
skoeva added a commit that referenced this issue Feb 12, 2025
@skoeva
frontend: EditorDialog: Handle incomplete input in docs tab
0261f4e 
This change gracefully handles incomplete or comment-only input from the
editor dialog in the documentation tab, preventing the app from crashing.

Fixes: #2854

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Feb 12, 2025
@skoeva
frontend: EditorDialog: Handle incomplete input in docs tab
3277311 
This change gracefully handles incomplete or comment-only input from the
editor dialog in the documentation tab, preventing the app from crashing.

Fixes: #2854

Signed-off-by: Evangelos Skopelitis <[email protected]>
@github-project-automation github-project-automation bot moved this from Queued to Done in Release Plan / Roadmap Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skoeva skoeva

Labels
frontend Issues related to the frontend kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

frontend: EditorDialog: Handle null YAML in docs tab kubernetes-sigs/headlamp
1 participant
@skoeva