Skip to content

Commit 6a31be4

Browse files
post-merge mypy/stubtest fixes. Allow any numpy generic or array in fillvalue.
1 parent 9cd78c9 commit 6a31be4

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

.github/stubtest-allowlist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,14 @@ netCDF4.NumericVarT
2929
netCDF4.Dimension.__reduce_cython__
3030
netCDF4.Dimension.__setstate_cython__
3131
netCDF4.Variable.auto_complex
32+
netCDF4.Variable.get_fill_value
3233
netCDF4.Variable.__iter__
3334
netCDF4._netCDF4.Dimension.__reduce_cython__
3435
netCDF4._netCDF4.Dimension.__setstate_cython__
3536
netCDF4._netCDF4.NC_DISKLESS
3637
netCDF4._netCDF4.NC_PERSIST
3738
netCDF4._netCDF4.Variable.auto_complex
39+
netCDF4._netCDF4.Variable.get_fill_value
3840
netCDF4._netCDF4.Variable.__iter__
3941
netCDF4._netCDF4.__reduce_cython__
4042
netCDF4._netCDF4.__setstate_cython__

src/netCDF4/__init__.pyi

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ class Dataset:
295295
least_significant_digit: int | None = None,
296296
significant_digits: int | None = None,
297297
quantize_mode: QuantizeMode = "BitGroom",
298-
fill_value: int | float | np.number | str | bytes | Literal[False] | None = None,
298+
fill_value: int | float | np.generic | str | bytes | Literal[False] | np.ndarray | None = None,
299299
chunk_cache: int | None = None,
300300
) -> Variable[NumericVarT]: ...
301301
@overload
@@ -318,7 +318,7 @@ class Dataset:
318318
least_significant_digit: int | None = None,
319319
significant_digits: int | None = None,
320320
quantize_mode: QuantizeMode = "BitGroom",
321-
fill_value: int | float | np.number | str | bytes | Literal[False] | None = None,
321+
fill_value: int | float | np.generic | str | bytes | Literal[False] | np.ndarray | None = None,
322322
chunk_cache: int | None = None,
323323
) -> Variable[str]: ...
324324
@overload
@@ -341,7 +341,7 @@ class Dataset:
341341
least_significant_digit: int | None = None,
342342
significant_digits: int | None = None,
343343
quantize_mode: QuantizeMode = "BitGroom",
344-
fill_value: int | float | np.number | str | bytes | Literal[False] | None = None,
344+
fill_value: int | float | np.generic | str | bytes | Literal[False] | np.ndarray | None = None,
345345
chunk_cache: int | None = None,
346346
) -> Variable: ...
347347
def renameVariable(self, oldname: str, newname: str) -> None: ...
@@ -450,7 +450,7 @@ class Variable(Generic[VarT]):
450450
least_significant_digit: int | None = None,
451451
significant_digits: int | None = None,
452452
quantize_mode: QuantizeMode = "BitGroom",
453-
fill_value: int | float | np.number | str | bytes | Literal[False] | None = None,
453+
fill_value: int | float | np.generic | str | bytes | Literal[False] | np.ndarray | None = None,
454454
chunk_cache: int | None = None,
455455
**kwargs: Any,
456456
) -> Variable[NumericVarT]: ...
@@ -475,7 +475,7 @@ class Variable(Generic[VarT]):
475475
least_significant_digit: int | None = None,
476476
significant_digits: int | None = None,
477477
quantize_mode: QuantizeMode = "BitGroom",
478-
fill_value: int | float | np.number | str | bytes | Literal[False] | None = None,
478+
fill_value: int | float | np.generic | str | bytes | Literal[False] | np.ndarray | None = None,
479479
chunk_cache: int | None = None,
480480
**kwargs: Any,
481481
) -> Variable[str]: ...
@@ -500,7 +500,7 @@ class Variable(Generic[VarT]):
500500
least_significant_digit: int | None = None,
501501
significant_digits: int | None = None,
502502
quantize_mode: QuantizeMode = "BitGroom",
503-
fill_value: int | float | np.number | str | bytes | Literal[False] | None = None,
503+
fill_value: int | float | np.generic | str | bytes | Literal[False] | np.ndarray | None = None,
504504
chunk_cache: int | None = None,
505505
**kwargs: Any,
506506
) -> Variable: ...
@@ -524,7 +524,7 @@ class Variable(Generic[VarT]):
524524
least_significant_digit: int | None = None,
525525
significant_digits: int | None = None,
526526
quantize_mode: QuantizeMode = "BitGroom",
527-
fill_value: int | float | np.number | str | bytes | Literal[False] | None = None,
527+
fill_value: int | float | np.generic | str | bytes | Literal[False] | np.ndarray | None = None,
528528
chunk_cache: int | None = None,
529529
**kwargs: Any,
530530
) -> None: ...

0 commit comments

Comments
 (0)