Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more node_modules/.bin directory in the debian package #101

Open
Skywalker13 opened this issue Jan 31, 2019 · 7 comments
Open

No more node_modules/.bin directory in the debian package #101

Skywalker13 opened this issue Jan 31, 2019 · 7 comments

Comments

@Skywalker13
Copy link

Skywalker13 commented Jan 31, 2019

Hi

I don't know exactly why and when but it seems that with an update a buster, the node_modules/.bin directory is no longer packaged. Any ideas?

I use the auto strategy (default) and node_modules is present

Thanks

@Skywalker13
Copy link
Author

Skywalker13 commented Jan 31, 2019

I think that's is related to #71 that breaks too much things... no more symlinks in .bin then no more .bin dir... and with the copy strategy the binaries in .bin/ are juste not usable anymore because it's no longer symlinks..

@heartsucker
Copy link
Owner

This sounds like it might be related to #71, yeah. I'm a little swamped with work things but I'll see if I can get around to doing a copy-with-dereference.

@heartsucker
Copy link
Owner

Ah #71 was already closed, so those should be referenced. Is the error you're experiencing in this ticket the same error as your mentioned in #71?

@Skywalker13
Copy link
Author

Yes, after more investigate it's the same. I'm looking for forking and fixing the regression ASAP because I must provide a working package today.

@Skywalker13
Copy link
Author

With this "revert" Xcraft-Inc@a317f93 it works as expected with the copy strategy. But with the auto strategy, I continue to lose the .bin directory :-(

@heartsucker
Copy link
Owner

Ok so would the solution to fix this for everyone be to:

  • do not dereference symlinks in node_modules/.bin
  • dereference all other symlinks

@Skywalker13
Copy link
Author

It should be fine most of times, even if IMO dereferencing symlinks looks wrong to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants