Skip to content

Commit 0e99003

Browse files
committed
Note reason for transitive setup functions
#168
1 parent 0b821b7 commit 0e99003

3 files changed

+3
-0
lines changed

workspace_setup_transitive.bzl

+1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ def hedron_compile_commands_setup_transitive(module_ctx = None):
3030

3131
# Currently nothing to do -> no-op.
3232
# So why is this even here? Enables future expansion (e.g to add transitive dependencies) without changing the user interface.
33+
# Originally added for rules_python, which we reverted, but are keeping this interface to be used once it's fixed. See https://github.com/hedronvision/bazel-compile-commands-extractor/issues/168 for details.
3334
pass
3435

3536

workspace_setup_transitive_transitive.bzl

+1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ def hedron_compile_commands_setup_transitive_transitive(module_ctx = None):
3030

3131
# Currently nothing to do -> no-op.
3232
# So why is this even here? Enables future expansion (e.g to add transitive dependencies) without changing the user interface.
33+
# Originally added for rules_python, which we reverted, but are keeping this interface to be used once it's fixed. See https://github.com/hedronvision/bazel-compile-commands-extractor/issues/168 for details.
3334
pass
3435

3536

workspace_setup_transitive_transitive_transitive.bzl

+1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ def hedron_compile_commands_setup_transitive_transitive_transitive(module_ctx =
3030

3131
# Currently nothing to do -> no-op.
3232
# So why is this even here? Enables future expansion (e.g to add transitive dependencies) without changing the user interface.
33+
# Originally added for rules_python, which we reverted, but are keeping this interface to be used once it's fixed. See https://github.com/hedronvision/bazel-compile-commands-extractor/issues/168 for details.
3334
pass
3435

3536

0 commit comments

Comments
 (0)