Skip to content

Commit 19808d6

Browse files
committed
Update sysroot notes now that #82 is closed
1 parent d7a2830 commit 19808d6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

refresh.template.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -735,8 +735,8 @@ def _all_platform_patch(compile_args: typing.List[str]):
735735
# For more context see: https://github.com/hedronvision/bazel-compile-commands-extractor/issues/21
736736
compile_args = (arg for arg in compile_args if not arg == '-fno-canonical-system-headers')
737737

738-
# Swap -isysroot for --sysroot to work around (probably) https://github.com/clangd/clangd/issues/1305
739-
# For context, see https://github.com/clangd/clangd/issues/1305
738+
# Swap -isysroot for --sysroot to work around some unknown sysroot bug in clangd.
739+
# For context, see https://github.com/hedronvision/bazel-compile-commands-extractor/issues/82
740740
# The = logic has to do with clang not accepting -isysroot=, but accepting --sysroot=. Note that -isysroot <path> is accepted, though undocumented.
741741
compile_args = ('-isysroot'+arg[len('--sysroot')+arg.startswith('--sysroot='):] if arg.startswith('--sysroot') else arg for arg in compile_args)
742742

0 commit comments

Comments
 (0)