Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📜 Adventures misses a title #5020

Closed
Felienne opened this issue Jan 22, 2024 · 1 comment
Closed

📜 Adventures misses a title #5020

Felienne opened this issue Jan 22, 2024 · 1 comment
Assignees
@hasan-sh
Labels
content issues related to adventure tabs

Comments

@Felienne
Copy link
Member

Describe the issue

Similar to #5019, the adventures title is also missing:
image

(https://hedy-alpha.herokuapp.com/public-adventures)

Maybe a good idea to check all related strings? And maybe to slab a test on the po files that English should never have "" as value?
@Felienne Felienne added the content issues related to adventure tabs label Jan 22, 2024
@Felienne Felienne mentioned this issue Jan 23, 2024
Merged
4 tasks
@hasan-sh
Copy link
Contributor

Similar to #5019, the adventures title is also missing:

I'll add and remove translation keys related to the public adventures in #4990

mergify bot pushed a commit that referenced this issue Feb 10, 2024
@Felienne
🧪 Test for empty strings in English po file (#5022)
478486c 
Fixes the testing part of #5020

**How to test**
The tests should pass when the content has been fixed 

**Checklist**
Done? Check if you have it all in place using this list: (mark with x if done)

- [X] Contains one of the PR categories in the name
- [X] Describes changes in the format above
- [X] Links to an existing issue or discussion
- [X] Has a "How to test" section

If you're unsure about any of these, don't hesitate to ask. We're here to help!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hasan-sh hasan-sh

Labels
content issues related to adventure tabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Felienne @hasan-sh