Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovery: assert that pong and neighbour messages are signed by the expected identity #2

Open
heikoheiko opened this issue Mar 1, 2015 · 3 comments

Comments

@heikoheiko
Copy link
Owner

No description provided.

heikoheiko referenced this issue in ethereum/pydevp2p Apr 15, 2015
@AFDudley
Copy link

This does not fix the failed detection at all. When I remove all of those checks and just run import pyelliptic everything works fine. I used macports to install openssl.

@heikoheiko
Copy link
Owner Author

this is a different #2 :)
the commit is here:
ethereum@b7b2a9f

did you update pydevp2p?

@AFDudley
Copy link

I did update it. The issue is the logic behind the import check is bad. It should first do the import pyelliptic, then check if the needed ciphers are there, then determine what to do about those missing ciphers.
As the code stands, pyelliptic correctly finds my ciphers no problem, but your test does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants